-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(OutputWatcher): use formatted string in log message #7493
Conversation
Sometimes line for output could contain '%s' or '0.0%' and this break OutputWatcher log function with error: ``` 18:42:47 msg = msg % self.args 18:42:47 ValueError: incomplete format File "/home/ubuntu/scylla-cluster-tests/sdcm/remote/libssh2_client/__init__.py", line 449, in _process_output watcher.submit_line(data) File "/home/ubuntu/scylla-cluster-tests/sdcm/remote/base.py", line 231, in submit_line self.log.debug("<%s>: " + line.rstrip('\n'), self.hostname) Message: '<%s>: Percent Repaired : 0.0%' Arguments: ('10.4.0.228',) ``` Change format for log message info self.log.debug("%s - %s', self.hostname, line)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mark the backports needed
actually looks breaking commit wasn't backported yet. If we backport it to 6.0 then we need to do with this one the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fruch linting failed on kafka test:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
adderssing it on #7498 |
Sometimes line for output could contain '%s' or '0.0%' and this break OutputWatcher log function with error:
Change format for log message info
self.log.debug("%s - %s', self.hostname, line)
Testing
PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)