Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring : custom demo, upgrades, adding prepared query #193

Merged
merged 3 commits into from
Mar 23, 2023

Conversation

tarzanek
Copy link
Collaborator

No description provided.

@tarzanek
Copy link
Collaborator Author

@guy9 and I noticed I didn't push the changes for last update of Spring app yet, fixing my backlog

@tarzanek tarzanek requested a review from guy9 March 22, 2023 15:20
@guy9
Copy link
Collaborator

guy9 commented Mar 23, 2023

Thanks @tarzanek . There is a lesson that uses the existing example , and I don't want it to break.
Can you add this as a new example (say in a new directory) instead of changing the existing one?

@tarzanek
Copy link
Collaborator Author

tarzanek commented Mar 23, 2023

@guy9 this change is fully backwards compatible, what worked before, still works
it also aligns to jdk 17
the only new thing is a prepared query for implementation of get by ID (as it should be)

I verified the lessons, fixed the postman example and version of binary to match it
so this PR should be safe to merge

@guy9
Copy link
Collaborator

guy9 commented Mar 23, 2023

LGTM

@guy9 guy9 merged commit 224bf7a into scylladb:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants