Cleanup of scyllaclient package
#1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In favor of github.com/scylladb/scylladb-swagger-go-client
zimnx
added
the
kind/cleanup
tnozicka
reviewed
Aug 7, 2023
zimnx
force-pushed
the
mz/refresh-scyllaclient
branch
from
df633f6
to
6b6decc
Compare
scyllaclient package was cleaned from unused code that we inherited by copy pasting entire package from Scylla Manager. Summary of changes: * Autogenerated raw swagger client is now taken from github.com/scylladb/scylladb-swagger-go-client. * Client logging is now unified with our project logging library. * Datacenter cache was removed - we don't use Datacenter information anywhere. * Unused functions were removed. * Unused transport middlewares were removed. * Unused config fields were removed. * Added Config validation.
zimnx
force-pushed
the
mz/refresh-scyllaclient
branch
from
6b6decc
to
60256dc
Compare
2 tasks
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tnozicka, zimnx The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scyllaclient package was cleaned from unused code that we inherited by
copy pasting entire package from Scylla Manager.
Summary of changes:
Prerequisites:
scylladb-swagger-go-clientrepository transfer is finished