Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ScyllaCluster nodes using Host ID #1312

Merged
merged 3 commits into from Aug 17, 2023
Merged

Replace ScyllaCluster nodes using Host ID #1312

merged 3 commits into from Aug 17, 2023

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented Aug 7, 2023 •
edited

Existing procedure of replacing nodes using their broadcasted IP address
is deprecated since 5.2. This change brings support for new procedure
where nodes are identified using their HostID.
HostID is better because it's constanct across entire node lifetime,
where IP address is not, which may cause ambiguity when node IP changes,
and node requires a replacement.

From user point of view, nothing changes, as the same label is used to
mark node to be replaced. Operator validates whether deployed ScyllaDB
version supports new procedure, and uses it when it does. In other case,
old procedure is executed.

Fixes #1311

Prerequisites:

@zimnx zimnx added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 7, 2023
@zimnx zimnx added this to the v1.10 milestone Aug 7, 2023
@zimnx zimnx force-pushed the mz/replace-node-uuid branch 3 times, most recently from 1600cec to 795b36b Compare August 8, 2023 08:18
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 8, 2023
@scylla-operator-bot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/release-note-label-needed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 8, 2023
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 8, 2023
@rzetelskik
Copy link
Member

Should #1313 be added as a prerequisite?

tnozicka
tnozicka reviewed Aug 9, 2023
View reviewed changes
pkg/api/scylla/v1/types_cluster.go Outdated Show resolved Hide resolved
pkg/controller/scyllacluster/sync_services.go Outdated Show resolved Hide resolved
pkg/controller/scyllacluster/sync_services.go Outdated Show resolved Hide resolved
pkg/controller/scyllacluster/sync_services.go Outdated Show resolved Hide resolved
pkg/controller/scyllacluster/sync_services.go Outdated Show resolved Hide resolved
pkg/sidecar/config/config.go Outdated Show resolved Hide resolved
pkg/sidecar/config/config.go Outdated Show resolved Hide resolved
test/e2e/set/scyllacluster/scyllacluster_replace.go Show resolved Hide resolved
test/e2e/utils/helpers.go Outdated Show resolved Hide resolved
test/e2e/utils/helpers.go Show resolved Hide resolved
rzetelskik
rzetelskik reviewed Aug 9, 2023
View reviewed changes
pkg/api/scylla/v1/types_cluster.go Outdated Show resolved Hide resolved
test/e2e/set/scyllacluster/scyllacluster_replace.go Outdated Show resolved Hide resolved
test/e2e/set/scyllacluster/scyllacluster_replace.go Show resolved Hide resolved
test/e2e/set/scyllacluster/scyllacluster_replace.go Outdated Show resolved Hide resolved
test/e2e/set/scyllacluster/scyllacluster_replace.go Outdated Show resolved Hide resolved
pkg/scyllaclient/config_client.go Outdated Show resolved Hide resolved
pkg/naming/constants.go Show resolved Hide resolved
pkg/scyllaclient/config_client.go Outdated Show resolved Hide resolved
@zimnx zimnx force-pushed the mz/replace-node-uuid branch 2 times, most recently from 3142881 to 5621f54 Compare August 14, 2023 15:20
tnozicka
tnozicka reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits, rest lgtm

thanks for the updates!

pkg/api/scylla/v1/types_cluster.go Outdated Show resolved Hide resolved
test/e2e/set/scyllacluster/scyllacluster_replace.go Show resolved Hide resolved
pkg/scyllafeatures/scyllafeatures.go Outdated Show resolved Hide resolved
pkg/scyllafeatures/scyllafeatures.go Outdated Show resolved Hide resolved
test/e2e/set/scyllacluster/scyllacluster_replace.go Outdated Show resolved Hide resolved
test/e2e/set/scyllacluster/scyllacluster_replace.go Show resolved Hide resolved
test/e2e/set/scyllacluster/scyllacluster_replace.go Show resolved Hide resolved
pkg/controller/scyllacluster/sync_services.go Outdated Show resolved Hide resolved
@tnozicka
Copy link
Member

except for #1312 (comment) , I think this is ready to land

@zimnx zimnx mentioned this pull request Aug 16, 2023
Closed
@zimnx zimnx enabled auto-merge August 16, 2023 08:31
tnozicka
tnozicka approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

tnozicka
tnozicka approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@scylla-operator-bot scylla-operator-bot bot added do-not-merge/contains-merge-commits and removed lgtm Indicates that a PR is ready to be merged. labels Aug 16, 2023
@tnozicka
Copy link
Member

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
tnozicka
tnozicka previously approved these changes Aug 16, 2023
View reviewed changes
@scylla-operator-bot scylla-operator-bot bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@zimnx zimnx force-pushed the mz/replace-node-uuid branch 2 times, most recently from 04d286e to da1ad93 Compare August 16, 2023 13:15
tnozicka
tnozicka previously approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zimnx
Replace ScyllaCluster nodes using Host ID
6274102 
Existing procedure of replacing nodes using their broadcasted IP address
is deprecated since 5.2. This change brings support for new procedure
where nodes are identified using their HostID.
HostID is better because it's constanct across entire node lifetime,
where IP address is not, which may cause ambiguity when node IP changes,
and node requires a replacement.

From user point of view, nothing changes, as the same label is used to
mark node to be replaced. Operator validates whether deployed ScyllaDB
version supports new procedure, and uses it when it does. In other case,
old procedure is executed.
@zimnx
Update autogenerated
27151a1
@zimnx
Limit CI e2e parallel suites to 8 tests at once
98f603f
@scylla-operator-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@scylla-operator-bot scylla-operator-bot bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2023
@scylla-operator-bot
Copy link
Contributor

@zimnx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/docs 98f603f link true /test docs

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zimnx zimnx disabled auto-merge August 17, 2023 09:16
@zimnx zimnx merged commit 7157fce into scylladb:master Aug 17, 2023
24 of 25 checks passed
@zimnx zimnx deleted the mz/replace-node-uuid branch August 17, 2023 09:16
@rzetelskik rzetelskik mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzetelskik rzetelskik rzetelskik left review comments

@tnozicka tnozicka tnozicka left review comments

Assignees

@tnozicka tnozicka

Labels
kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement node replacement using node HostID
3 participants
@zimnx @rzetelskik @tnozicka