Enhancement proposal for replacing nodes using their HostIDs #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimnx
added
priority/important-soon
scylla-operator-bot
bot
added
the
size/L
zimnx
force-pushed
the
mz/replace-node-uuid-proposal
branch
from
8da0f88
to
011c5cf
Compare
rzetelskik
reviewed
Aug 9, 2023
enhancements/proposals/1311-replace-nodes-using-hostid/README.md
Outdated
Show resolved
Hide resolved
enhancements/proposals/1311-replace-nodes-using-hostid/README.md
Outdated
Show resolved
Hide resolved
enhancements/proposals/1311-replace-nodes-using-hostid/README.md
Outdated
Show resolved
Hide resolved
enhancements/proposals/1311-replace-nodes-using-hostid/README.md
Outdated
Show resolved
Hide resolved
enhancements/proposals/1311-replace-nodes-using-hostid/README.md
Outdated
Show resolved
Hide resolved
enhancements/proposals/1311-replace-nodes-using-hostid/README.md
Outdated
Show resolved
Hide resolved
2 tasks
tnozicka
reviewed
Aug 9, 2023
enhancements/proposals/1311-replace-nodes-using-hostid/README.md
Outdated
Show resolved
Hide resolved
enhancements/proposals/1311-replace-nodes-using-hostid/README.md
Outdated
Show resolved
Hide resolved
tnozicka
force-pushed
the
mz/replace-node-uuid-proposal
branch
from
011c5cf
to
460206a
Compare
zimnx
force-pushed
the
mz/replace-node-uuid-proposal
branch
2 times, most recently
from
93fbe68
to
3baab9a
Compare
Currently, the Scylla Operator uses IP addresses of a node to identify which node should be replaced. The issue is that depending on the ScyllaCluster configuration, IP addresses might be ephemeral so it’s error prone to use it as an identifier as they may change during when the procedure is executed. Because there is a better stable alternative, IP address approach became deprecated, hence we need to shift to it. Details can be found in actual enhancement.
tnozicka
force-pushed
the
mz/replace-node-uuid-proposal
branch
from
3baab9a
to
27fac54
Compare
scylla-operator-bot
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tnozicka, zimnx The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Scylla Operator uses IP addresses of a node to identify which node should be replaced. The issue is that depending on the ScyllaCluster configuration, IP addresses might be ephemeral so it’s error prone to use it as an identifier as they may change during when the procedure is executed. Because there is a better stable alternative, IP address approach became deprecated, hence we need to shift to it.
Details can be found in actual enhancement.
Fixes #1314