-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add informers, listers, full ScyllaCluster reconciliation, typed clients and much more #534
Conversation
fd81ec5
to
c245100
Compare
096e019
to
3ca32f5
Compare
312beeb
to
58f1c49
Compare
5db8369
to
37ad2ca
Compare
4b7e631
to
5eaf2cb
Compare
@zimnx thanks for the first round, comments addressed |
fixed the new scale down test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2nd batch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last batch for this iteration. I like changes very much, code looks very mature. Awesome work!
pkg/thirdparty/k8s.io/kubernetes/pkg/controller/controller_ref_manager.go
Outdated
Show resolved
Hide resolved
Thanks for the review. I'v addressed most of it but there are still some comments I need to address tomorrow. |
1a2bef3
to
6ee0746
Compare
16e40cc
to
69660b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job!
Description of your changes:
Which issue is resolved by this Pull Request:
Fixes #469
Fixes #470
Fixes #429
Fixes #475
Fixes #469
Fixes #513
Fixes #514
Fixes #459
Fixes #607
Fixes #558
Fixes #526
Fixes #520
Followups
Audit results
Over the run of an e2e suite (~48m)
37085/48 = ~772 API calls per minute (doesn't include the side car and health checks)
the longest lived scylla cluster (health checks + side car) made 2466 API calls
e2e run took about ~46m
6569/46= ~143 API calls per minute (doesn't include the side car and health checks)
the longest lived scylla cluster (health checks + side car) made 155 API calls
Final results
6569/37085=~18% of API calls per controllers
155/2466=~6% of API calls per scyllacluster