Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service DNS names for in-cluster communication #576

Merged
merged 2 commits into from
May 4, 2021

Conversation

tnozicka
Copy link
Member

@tnozicka tnozicka commented May 3, 2021

Description of your changes:
Cluster suffix differs in each cluster. For in-cluster communication we should be using only .svc suffix.

Which issue is resolved by this Pull Request:
Resolves #575

@tnozicka tnozicka added the kind/bug Categorizes issue or PR as related to a bug. label May 3, 2021
@tnozicka tnozicka added this to the v1.3 milestone May 3, 2021
@tnozicka tnozicka requested a review from zimnx May 3, 2021 10:40
zimnx
zimnx previously approved these changes May 4, 2021
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'll merge it after #574

Cluster suffix differs in each cluster. For in-cluster communication we
should be using only .svc suffix.
@tnozicka
Copy link
Member Author

tnozicka commented May 4, 2021

(clean rebase)

@zimnx zimnx enabled auto-merge May 4, 2021 08:50
@zimnx zimnx merged commit 3dc7aca into scylladb:master May 4, 2021
@tnozicka tnozicka deleted the fix-dns-suffix branch May 4, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scylla-manager: doesn't work with non-default TLD (.cluster.local)
2 participants