Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scylla_post_install.sh: "[ $RHEL ]" does not work for RHEL, it only detects CentOS #16040

Closed
syuu1228 opened this issue Nov 13, 2023 · 1 comment
Closed

scylla_post_install.sh: "[ $RHEL ]" does not work for RHEL, it only detects CentOS #16040

syuu1228 opened this issue Nov 13, 2023 · 1 comment

Comments

@syuu1228
Copy link
Contributor

On scylla_post_install.sh, Redhat variants detection code only references $ID_LIKE:

RHEL=$(echo $ID_LIKE | grep -oi rhel)

https://github.com/scylladb/scylladb/blob/master/scylla_post_install.sh#L21

This will work finely on CentOS, but doesn't work on RHEL itself.
To make it work correctly we also need to check $ID = "rhel".
syuu1228 added a commit to syuu1228/scylla that referenced this issue Nov 13, 2023
@syuu1228
scylla_post_install.sh: detect RHEL correctly
08696d5 
$ID_LIKE = "rhel" works only on RHEL compatible OSes, not for RHEL
itself.
To detect RHEL correctly, we also need to check $ID = "rhel".

Fixes scylladb#16040
@syuu1228 syuu1228 mentioned this issue Nov 13, 2023
Closed
avikivity pushed a commit that referenced this issue Nov 20, 2023
@syuu1228 @avikivity
scylla_post_install.sh: detect RHEL correctly
2cb7094 
$ID_LIKE = "rhel" works only on RHEL compatible OSes, not for RHEL
itself.
To detect RHEL correctly, we also need to check $ID = "rhel".

Fixes #16040

Closes #16041

(cherry picked from commit 338a949)
avikivity pushed a commit that referenced this issue Nov 20, 2023
@syuu1228 @avikivity
scylla_post_install.sh: detect RHEL correctly
c98b22a 
$ID_LIKE = "rhel" works only on RHEL compatible OSes, not for RHEL
itself.
To detect RHEL correctly, we also need to check $ID = "rhel".

Fixes #16040

Closes #16041

(cherry picked from commit 338a949)
@avikivity
Copy link
Member

Backported to 5.1, 5.2, 5.4.

avikivity pushed a commit that referenced this issue Nov 20, 2023
@syuu1228 @avikivity
scylla_post_install.sh: detect RHEL correctly
c8fdd59 
$ID_LIKE = "rhel" works only on RHEL compatible OSes, not for RHEL
itself.
To detect RHEL correctly, we also need to check $ID = "rhel".

Fixes #16040

Closes #16041

(cherry picked from commit 338a949)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scylla_post_install.sh: detect RHEL correctly syuu1228/scylla
3 participants
@syuu1228 @avikivity @scylladb-promoter