Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scylla_post_install.sh: detect RHEL correctly #16041

Closed
wants to merge 1 commit into from
Closed

scylla_post_install.sh: detect RHEL correctly #16041

wants to merge 1 commit into from

Conversation

syuu1228
Copy link
Contributor

$ID_LIKE = "rhel" works only on RHEL compatible OSes, not for RHEL itself.
To detect RHEL correctly, we also need to check $ID = "rhel".

Fixes #16040

@syuu1228
scylla_post_install.sh: detect RHEL correctly
08696d5 
$ID_LIKE = "rhel" works only on RHEL compatible OSes, not for RHEL
itself.
To detect RHEL correctly, we also need to check $ID = "rhel".

Fixes scylladb#16040
@github-actions github-actions bot deleted a comment from aws-amplify-us-east-2 bot Nov 13, 2023
@scylladb-promoter
Copy link
Contributor

🟢 CI State: SUCCESS

✅ - Build
✅ - Sanity Tests
✅ - Unit Tests

Build Details:

tchaikov
tchaikov approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

avikivity pushed a commit that referenced this pull request Nov 20, 2023
@syuu1228 @avikivity
scylla_post_install.sh: detect RHEL correctly
2cb7094 
$ID_LIKE = "rhel" works only on RHEL compatible OSes, not for RHEL
itself.
To detect RHEL correctly, we also need to check $ID = "rhel".

Fixes #16040

Closes #16041

(cherry picked from commit 338a949)
avikivity pushed a commit that referenced this pull request Nov 20, 2023
@syuu1228 @avikivity
scylla_post_install.sh: detect RHEL correctly
c98b22a 
$ID_LIKE = "rhel" works only on RHEL compatible OSes, not for RHEL
itself.
To detect RHEL correctly, we also need to check $ID = "rhel".

Fixes #16040

Closes #16041

(cherry picked from commit 338a949)
avikivity pushed a commit that referenced this pull request Nov 20, 2023
@syuu1228 @avikivity
scylla_post_install.sh: detect RHEL correctly
c8fdd59 
$ID_LIKE = "rhel" works only on RHEL compatible OSes, not for RHEL
itself.
To detect RHEL correctly, we also need to check $ID = "rhel".

Fixes #16040

Closes #16041

(cherry picked from commit 338a949)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaikov tchaikov tchaikov approved these changes

@avikivity avikivity Awaiting requested review from avikivity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scylla_post_install.sh: "[ $RHEL ]" does not work for RHEL, it only detects CentOS
3 participants
@syuu1228 @scylladb-promoter @tchaikov