schema::describe: print 'synchronous_updates' only if it was specified #14925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While describing materialized view, print `synchronous_updates` option only if the tag is present in schema's extensions map. Previously if the key wasn't present, the default (false) value was printed. Fixes: scylladb#14924
bhalevy
reviewed
Aug 2, 2023
|
|
||
| return *tag_opt == "true"; | ||
| static std::optional<std::string> is_update_synchronously_view(const schema& s) { | ||
| return db::find_tag(s, db::SYNCHRONOUS_VIEW_UPDATES_TAG_KEY); |
There was a problem hiding this comment.
I think that open-coding this in the call site might be clearer.
If you still want to wrap it, I'd rename the function accordingly, e.g. get_update_synchronously_view_opt.
|
@bhalevy By accident I've created this PR from my repo clone's master, I'll close this one and open new from a separate branch and without this unnecessary wrapping function |
|
CI state |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While describing materialized view, print
synchronous_updatesoption only if the tag is present in schema's extensions map. Previously if the key wasn't present, the default (false) value was printed.Fixes: #14924
Refers: https://github.com/scylladb/scylla-dtest/issues/3324