Skip to content

Commit

Permalink
install-dependencies.sh: add libudev-dev and systemd-devel
Browse files Browse the repository at this point in the history
Seastar supports both static and dynamic linkage. and we have
command line example in README.md to statically link against
Seastar. this means, all of its linkages are statically linked.

if hwloc is statically linked. it would bring into libudev, See

```
$ pkg-config --libs --cflags --static hwloc
-lhwloc -lm -ludev -lpthread
```
on Debian and its derivative distros, libudev.so is packaged in
libudev-dev, while on Fedora and its derivative distros, libudev.so
in systemd-devel.

in this change, these packages are included in install-dependencies.sh,
so the building system can have access to them when linking Seastar
statically. please note, these packages are not dependencies of
libhwloc-dev or hwloc-devel. Because, in general, distro packacage
guidelines encourage maintainers to package shared library if possible,
and reuse the shared libraries redistributed by the distro whenever
appropriate.

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
  • Loading branch information
tchaikov committed Dec 11, 2023
1 parent 72fe971 commit 3cd63c8
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions install-dependencies.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ debian_packages=(
libgnutls28-dev
liblz4-dev
libsctp-dev
libudev-dev
liburing-dev
gcc
make
Expand Down Expand Up @@ -86,6 +87,7 @@ redhat_packages=(
meson
python3
python3-pyelftools
systemd-devel
systemtap-sdt-devel
libtool
cmake
Expand Down

0 comments on commit 3cd63c8

Please sign in to comment.