github: s/clang++-18/clang++/ #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
in b822c94, we removed some "#include":s in std-compat.hh. despite that the Seastar library and all tests still compile. some header are not self-contained anymore. Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
in 28b0555, we switched from ubuntu:jammy to fedora:40 as the building environment of our CI workflow. and we replaced the input parameter "clang++-18" in test.yml with "clang++", because in fedora:40, the clang++ executable does not have the postfix as the clang-18 installed by the setup-cpp action. but we failed to update all of them in that change, that's why the "check header" step was not performed after that change. in this change, we replace that last "clang++-18" in the workflow to "clang++". Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in 28b0555, we switched from ubuntu:jammy to fedora:40 as the building environment of our CI workflow. and we replaced the input parameter "clang++-18" in test.yml with "clang++", because in fedora:40, the clang++ executable does not have the postfix as the clang-18 installed by the setup-cpp action.
but we failed to update all of them in that change, that's why the "check header" step was not performed after that change.
in this change, we replace that last "clang++-18" in the workflow to "clang++".