Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: s/clang++-18/clang++/ #2267

Merged
merged 2 commits into from
May 25, 2024
Merged

github: s/clang++-18/clang++/ #2267

merged 2 commits into from
May 25, 2024

Commits on May 25, 2024

  1. include: include used headers 

    in b822c94, we removed some "#include":s in std-compat.hh. despite
that the Seastar library and all tests still compile. some header are
not self-contained anymore.

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
    @tchaikov
    tchaikov committed May 25, 2024
    Configuration menu
    Copy the full SHA
    343e601 View commit details
    Browse the repository at this point in the history

  2. github: s/clang++-18/clang++/ 

    in 28b0555, we switched from ubuntu:jammy to fedora:40 as the
building environment of our CI workflow. and we replaced the
input parameter "clang++-18" in test.yml with "clang++", because
in fedora:40, the clang++ executable does not have the postfix
as the clang-18 installed by the setup-cpp action.

but we failed to update all of them in that change, that's why
the "check header" step was not performed after that change.

in this change, we replace that last "clang++-18" in the
workflow to "clang++".

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
    @tchaikov
    tchaikov committed May 25, 2024
    Configuration menu
    Copy the full SHA
    245ec8f View commit details
    Browse the repository at this point in the history