Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout should be configurable per page #229

Closed
dgarcia360 opened this issue Oct 6, 2021 · 0 comments · Fixed by #230
Closed

Layout should be configurable per page #229

dgarcia360 opened this issue Oct 6, 2021 · 0 comments · Fixed by #230
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dgarcia360
Copy link
Collaborator

dgarcia360 commented Oct 6, 2021

Motivation

The option hide_sidebar_index applies to all the versions of the project. However, the new design does not add a sidebar on the main page, breaking the UI of previous versions that do not have the new landing page design.

To solve this issue, we could decide to show or hide the side-nav per page instead of per project. For example, we can create a new custom directive :full-width: that's added a the top of every file where you don't want to show the sidebar.

This change lets projects have previous documentation versions with sidebar, whereas in new versions the sidebar remains hidden.

Proposal

@dgarcia360 dgarcia360 added the enhancement New feature or request label Oct 6, 2021
@dgarcia360 dgarcia360 self-assigned this Oct 6, 2021
@dgarcia360 dgarcia360 changed the title No sidebar should be configurable per page Layout should be configurable per page Oct 6, 2021
@dgarcia360 dgarcia360 added this to the 1.1 milestone Oct 27, 2021
@dgarcia360 dgarcia360 modified the milestones: 1.0.6, 1.2 Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant