Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customizable layout options per page #230

Merged
merged 11 commits into from
Jan 12, 2022

Conversation

dgarcia360
Copy link
Collaborator

@dgarcia360 dgarcia360 commented Oct 6, 2021

Closes #229 (comment)

How to test this PR

  1. Clone this PR. For more information, see Cloning pull requests locally.

  2. Enter the docs folder, and run:

make preview
  1. Open http://127.0.0.1:5500/ with your favorite browser. The home page layout must look the same as https://sphinx-theme.scylladb.com/stable/. Furthermore, the internal page layout (e.g. Installation) must look the same as before https://sphinx-theme.scylladb.com/stable/getting-started/installation.html.

Releasing this change

This PR introduces breaking changes. To ensure it doesn't affect other projects with the new theme, I'll release a new version increasing the minor number. Unfortunately, this will prevent projects from receiving the update automatically.

After releasing 1.1, I'll submit PRs for the projects care-pet and sphinx-scylla-monitoring to install the latest version.

@dgarcia360 dgarcia360 merged commit 2731e75 into scylladb:master Jan 12, 2022
@dgarcia360 dgarcia360 deleted the no-side-nav-metadata branch January 12, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout should be configurable per page
1 participant