Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top bar blink #382

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Conversation

dgarcia360
Copy link
Collaborator

If a project has the top-bar enabled, but the user closes it, the bar continues appearing for milliseconds when the user navigates through the site.

image

To reproduce the bug:

  1. Enter https://sphinx-theme.scylladb.com/stable/
  2. Close the topbar.
  3. Refresh the page with F5 several times.

You will see the topbar for a short period of time.

This PR prevents this bug from happening.

@dgarcia360 dgarcia360 added the bug Something isn't working label Feb 26, 2022
@netlify
Copy link

netlify bot commented Feb 26, 2022

✔️ Deploy Preview for sphinx-theme ready!

🔨 Explore the source changes: 4b7993c

🔍 Inspect the deploy log: https://app.netlify.com/sites/sphinx-theme/deploys/621a074cc6a2d50008ee9ba9

😎 Browse the preview: https://deploy-preview-382--sphinx-theme.netlify.app

@dgarcia360 dgarcia360 added this to the 1.2 milestone Mar 1, 2022
@dgarcia360 dgarcia360 merged commit 9517eeb into scylladb:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant