Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new metadata options: hide-sidebar & hide-secondary-sidebar #402

Merged
merged 9 commits into from
Mar 17, 2022

Conversation

dgarcia360
Copy link
Collaborator

@dgarcia360 dgarcia360 commented Mar 15, 2022

Related issue #397

Changes

  • Adds an option to override the hero box background and default padding.
  • Adds two additional options to hide the sidebar or secondary-sidebar per page instead than both of them at the same time.
  • Adds a GitHub Action to run the theme tests automatically when some of the theme files are edited.

How it works

Now projects can show the sidebars in the home page while showing the hero-box component with the new page option :hide-sidebar: and :hide-secondary-sidebar:.

Preview

Home page with sidebar: https://deploy-preview-402--sphinx-theme.netlify.app/

@netlify
Copy link

netlify bot commented Mar 15, 2022

✔️ Deploy Preview for sphinx-theme canceled.

🔨 Explore the source changes: e55e277

🔍 Inspect the deploy log: https://app.netlify.com/sites/sphinx-theme/deploys/623230ec672acf0009a3fed4

@dgarcia360 dgarcia360 marked this pull request as draft March 15, 2022 11:46
@dgarcia360 dgarcia360 changed the title Add hide-sidebar & hide-secondary-sidebar metadata Add new metadata options: hide-sidebar & hide-secondary-sidebar Mar 15, 2022
@dgarcia360
Copy link
Collaborator Author

@annastuchlik @tzach I've just changed the pull-request from draft mode to "Ready for review".

@dgarcia360 dgarcia360 marked this pull request as ready for review March 15, 2022 17:39
Copy link
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgarcia360 dgarcia360 merged commit c2f645a into scylladb:master Mar 17, 2022
@dgarcia360 dgarcia360 deleted the modifications-landing-hero branch March 17, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants