Use executor in dtls_acceptor_callback_helper #4
Conversation
include/asio/ssl/dtls/acceptor.hpp
Outdated
| @@ -767,6 +768,7 @@ class acceptor | |||
| , ah_(std::move(ah)) | |||
| , sock_(sock) | |||
| , buffer_(buffer) | |||
| , work_(associated_executor<AcceptHandler>::get(ah)) | |||
There was a problem hiding this comment.
hmm...no, I don't think this is right. The work should be using the executor of the I/O object and not the executor associated with the completion handler. The completion handler's executor will automatically get a work guard when you submit your own composed operation to an Asio I/O operation (I think you are calling the datagram socket's async_receive_from?)
Asio (and therefore Networking TS) require two executor work guards. One of them you get for "free" when you call an I/O operation, and the other one you have to provide yourself.
| @@ -767,6 +768,7 @@ class acceptor | |||
| , ah_(std::move(ah)) | |||
There was a problem hiding this comment.
I think you want to be using std::forward in a deduced context, example:
https://github.com/boostorg/beast/blob/1da229a27c6f0539d422bcedbcf47cfe2517164a/include/boost/beast/http/impl/read.ipp#L66
You really should study Beast and the composed operation tutorial! This is a very complex topic and it is super easy to make mistakes (happens to me all the time).
include/asio/ssl/dtls/acceptor.hpp
Outdated
| using executor_type = asio::associated_executor_t< | ||
| AcceptHandler, decltype(std::declval<DatagramSocketType&>().get_executor())>; | ||
|
|
||
| using executor_type = typename associated_executor<AcceptHandler>::type; |
There was a problem hiding this comment.
I think you had it right the first time, this now looks wrong. See:
https://github.com/boostorg/beast/blob/1da229a27c6f0539d422bcedbcf47cfe2517164a/include/boost/beast/http/impl/read.ipp#L79
Readme.md
Outdated
| A dtls\_context allows to use methos like dtls\_client which a normal ssl::context | ||
| does not. A dtls\_context does not allow stream based methos like tlsv12\_server. | ||
|
|
||
|
|
sdamm
force-pushed
the
add_executor_for_acceptor
branch
from
a5908a5
to
ea75d74
Compare
include/asio/ssl/dtls/acceptor.hpp
Outdated
| @@ -282,7 +280,7 @@ class acceptor | |||
| ASIO_SYNC_OP_VOID set_option(const SettableSocketOption& option, | |||
| asio::error_code& ec) | |||
| { | |||
| this->get_service().set_option(this->get_implementation(), option, ec); | |||
src/examples/server/main.cpp
Outdated
| @@ -42,6 +42,10 @@ class DTLS_Server | |||
| : m_acceptor(serv, ep) | |||
| , ctx_(ctx) | |||
| { | |||
| asio::socket_base::reuse_address option(true); | |||
| m_acceptor.set_option(option); | |||
There was a problem hiding this comment.
Consider:
m_acceptor.set_option(asio::socket_base::reuse_address option(true));
4540ede
to
5a1fbcf
Compare
No description provided.