Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger backend now separates multiple dynamic type instances #148

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

hindsholm
Copy link
Contributor

This is a fix for issue #147 .
The fix contains code to generate separate dynamic Json types in the swagger backend so that e.g. responses generated with the javax.json builders will give correct results.
There is also a test for the issue.
Some other tests needed small changes because they actually relied on the erratic behavior.
I also had to introduce a resetDynamicCounter() method in the TypeIdentifier class in order to test because it uses a static variable for counting which is not otherwise accessible.

@sdaschner sdaschner merged commit fd29b11 into sdaschner:master Mar 27, 2018
@sdaschner
Copy link
Owner

Thanks for contributing and thanks a lot for adding tests, so many times they are neglected :-)

I saw the reset method. I added it into a test scope functionality that resets it via reflection. Not the nicest code, but I personally prefer this over adding functionality to production code.

@hindsholm hindsholm deleted the schemafix branch March 28, 2018 09:18
@hindsholm hindsholm mentioned this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants