Skip to content
This repository has been archived by the owner on Feb 3, 2018. It is now read-only.

Refactor sourceMgr #196

Merged
merged 43 commits into from
Apr 4, 2017
Merged

Refactor sourceMgr #196

merged 43 commits into from
Apr 4, 2017

Commits on Mar 29, 2017

  1. Initial sketch of new approach to sm concurrency

    Very much a WIP.
    sdboyer committed Mar 29, 2017
    Configuration menu
    Copy the full SHA
    435120b View commit details
    Browse the repository at this point in the history
  2. Add callManager

    sdboyer committed Mar 29, 2017
    Configuration menu
    Copy the full SHA
    83499b9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ac0a291 View commit details
    Browse the repository at this point in the history
  4. Fixups in response to review

    sdboyer committed Mar 29, 2017
    Configuration menu
    Copy the full SHA
    a72135d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fb146b4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7262376 View commit details
    Browse the repository at this point in the history
  7. Convert source, maybeSource to new cache system

    Also change maybeSource.try() signatures to take an injected cache, as
    well as a context. ProjectAnalyzer was also removed as a struct field on
    baseVCSSource.
    sdboyer committed Mar 29, 2017
    Configuration menu
    Copy the full SHA
    b55d922 View commit details
    Browse the repository at this point in the history
  8. Make glide happy

    sdboyer committed Mar 29, 2017
    Configuration menu
    Copy the full SHA
    fc4c538 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ff7e046 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5f4c226 View commit details
    Browse the repository at this point in the history
  11. Remove dead code, refactor tests so it compiles

    There are still a number of test failures, including some pointing to
    problems in the new implementation.
    sdboyer committed Mar 29, 2017
    Configuration menu
    Copy the full SHA
    7ec3c9c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    070cc51 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    91fc75a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    7e8801c View commit details
    Browse the repository at this point in the history
  15. Fix dangling var

    sdboyer committed Mar 29, 2017
    Configuration menu
    Copy the full SHA
    29dcabd View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    13bc00d View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    96bd8df View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    de3035d View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2017

  1. Configuration menu
    Copy the full SHA
    faedb0a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e6ca116 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1e7cb71 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dd1cc7a View commit details
    Browse the repository at this point in the history
  5. Convert source methods to take only Revisions

    Responsibility for converting Versions to Revisions had already been
    moved up into SourceGateway, but this interface change formalizes it.
    sdboyer committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    4a49499 View commit details
    Browse the repository at this point in the history
  6. Remove storeVersionMap() calls from source

    This is done entirely on the outside by the sourceGateway. Also,
    condense the gitSource.doListVersions() implementation down into just
    listVersions().
    sdboyer committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    c26166d View commit details
    Browse the repository at this point in the history
  7. Make projectInfo entirely internal to source cache

    Exposing the type as part of any function signature served no purpose
    other than adding a bit of unnecessary indirection.
    sdboyer committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    1c94d43 View commit details
    Browse the repository at this point in the history
  8. Integrate context for essential vcs cmds

    get, update, and listVersions are changed. There's a lot more to do
    here, but these are the most essential ones.
    sdboyer committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    77721f3 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2017

  1. Configuration menu
    Copy the full SHA
    0e6a532 View commit details
    Browse the repository at this point in the history
  2. s/callManager/supervisor/g

    sdboyer committed Mar 31, 2017
    Configuration menu
    Copy the full SHA
    ace80fb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    69d5059 View commit details
    Browse the repository at this point in the history
  4. Re-enable multi fetch test

    This is a great milestone. Reliable passage of that test demonstrates
    that the sourceMgr can not only manage very heavy concurrency and
    strongly suggest that the sourceGateway's dependent ordering logic is
    correct (within the four included methods, anyway), but it also
    that Release() correctly waits for all subprocess calls to end before
    returning.
    sdboyer committed Mar 31, 2017
    Configuration menu
    Copy the full SHA
    89566ce View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2bbb626 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    adc5291 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2017

  1. Configuration menu
    Copy the full SHA
    5a6e64c View commit details
    Browse the repository at this point in the history
  2. Make ProjectAnalyzer a solver param, not the sm

    This was really always the intended model - there's no reason a
    SourceManager needs to be permanently coupled with just one analyzer.
    It's perfectly sufficient to provide one as an argument to the relevant
    methods.
    
    Fixes #195.
    sdboyer committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    38bedf4 View commit details
    Browse the repository at this point in the history
  3. More source-related cleanup and cruft removal.

    * Move baseVCSSource into vcs_source.go
    * Rename source_test.go to vcs_source_test.go
    * Remove sourceExistence type and remaining uses of it
    sdboyer committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    4a9a453 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ef6e6d3 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2017

  1. Add sourceGateway tests

    This test isn't exhaustive, but it covers the basics.
    sdboyer committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    564fe67 View commit details
    Browse the repository at this point in the history
  2. chan instead of real sigs in TestSignalHandling

    Using actual signals was far too flaky in tests.
    sdboyer committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    2c2f561 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a3c79f3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8f20ffd View commit details
    Browse the repository at this point in the history
  5. Rename update() to fetch() in local repo interface

    This more accurately reflects how we were actually using the method for
    some time, as well as what we'd more recently modified the method to do.
    sdboyer committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    0eddf21 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d59d8a6 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2017

  1. Configuration menu
    Copy the full SHA
    01e3ba5 View commit details
    Browse the repository at this point in the history