Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between CLs without reviewers and WIPs #21

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

adg
Copy link
Contributor

@adg adg commented Apr 16, 2020

There should be a distinction between CLs that have been sent out for
review but that do not have assigned reviewers, and those that are
published to Gerrit with the "work in progress" label attached.

This change splits these distinct states into separate categories with
different labels, but they still use the same grey icon as before (now
renamed to "not_ready").

@sdefresne
Copy link
Owner

Thank you for the changes.

You'll also need to make some changes to src/popup.css to add support for the new class noReviewers and workInProgress, and remove the notMailed class. I guess you can probably copy the rules for notMailed twice, once for noReviewers, the other for workInProgress.

Once this is done, I'll merge the pull request.

@sdefresne
Copy link
Owner

sdefresne commented Apr 16, 2020

The following should be enough:

diff --git a/src/popup.css b/src/popup.css
index 75ec212..9793288 100644
--- a/src/popup.css
+++ b/src/popup.css
@@ -64,7 +64,11 @@ table {
   background: #00796b;
 }
 
-.notMailed > .sectionheader {
+.noReviewers > .sectionheader {
+  background: #bdbdbd;
+}
+
+.workInProgress > .sectionheader {
   background: #bdbdbd;
 }
 
@@ -104,8 +108,8 @@ table {
   text-overflow: ellipsis;
 }
 
-.approved .author, .notMailed .author, .outgoingRequiringAttention .author,
-.stale .author {
+.approved .author, .noReviewers .author, .outgoingRequiringAttention .author,
+.stale .author, .workInProgress .author {
   display: none;
 }

Though maybe we want to use different colors for Work In Progress and No Reviewer states.

There should be a distinction between CLs that have been sent out for
review but that do not have assigned reviewers, and those that are
published to Gerrit with the "work in progress" label attached.

This change splits these distinct states into separate categories with
different labels, but they still use the same grey icon as before (now
renamed to "not_ready").
@adg
Copy link
Contributor Author

adg commented Apr 16, 2020

Done.

Copy link
Owner

@sdefresne sdefresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@sdefresne sdefresne merged commit b02f4b0 into sdefresne:master Apr 17, 2020
@adg
Copy link
Contributor Author

adg commented Apr 19, 2020

Thanks for the handy extension! =D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants