Hide discrete logarithm k such that H = kG #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdiehl
reviewed
May 31, 2019
src/LSAG.hs
Outdated
| -- h = [H(L)] | ||
| h = generateH g curve0 (show $ hashPubKeys curve0 pubKeys) | ||
|
|
||
| -- h = ECC.pointBaseMul curve0 (hashPubKeys curve0 pubKeys) |
There was a problem hiding this comment.
Probably don't need this anymore.
src/LSAG.hs
Outdated
| generateH :: ECC.Point -> ECC.Curve -> [Char] -> ECC.Point | ||
| generateH g curve extra = | ||
| case yM of | ||
| Nothing -> generateH g curve (toS $ '1':extra) |
There was a problem hiding this comment.
The use of this magic '1' character is a little odd. What's the context on this choice?
There was a problem hiding this comment.
x is derived from the hash. The algorithm needs to iterate to generate a new x when there isn't a y s.t. y = x^3 + 7 mod p. We need to deterministically create a new hash from the existing hash. 1 is an arbitrary change to the existing hash
There was a problem hiding this comment.
Do you have any suggestions to make it more sensible?
There was a problem hiding this comment.
Added a name to the magic number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #5