Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to support serilization #30

Merged
merged 3 commits into from Jun 6, 2020
Merged

Updates to support serilization #30

merged 3 commits into from Jun 6, 2020

Conversation

sumo
Copy link
Contributor

@sumo sumo commented Jun 6, 2020

Pull Request Checklist

  • [ X] Update ChangeLog.md
  • [ X] Tests are passing.
  • [ X] Benchmarks are not regressing.

I've build serialisation in a separate library but unfortunately there is no equivalent to fromE for RootsOfUnity so have had to add one in.

Also the current bounds don't build when cabal selects protolude-0.3 because :% for rationals has been removed so I've included a fix.

Copy link
Owner

@sdiehl sdiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. Out of curiosity what serialisation are you supporting?

@sdiehl sdiehl merged commit ad82cd2 into sdiehl:master Jun 6, 2020
@sumo
Copy link
Contributor Author

sumo commented Jun 7, 2020

Thanks for merging, any chance you could push to hackage as well?

All looks good to me. Out of curiosity what serialisation are you supporting?

Current MCL (https://hg.sr.ht/~sumo/pairing-serialize) so I can use the pairing library with with MCL WASM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants