Fix rm asking to remove file on some zsh

[felipecrs]

I'm trying to fix the following:

❯ sdk install java
==== BROADCAST =================================================================
* 2021-01-07: mvnd 0.3.0 available on SDKMAN! https://git.io/JLxCq
* 2021-01-06: micronaut 2.2.3 available on SDKMAN!
* 2021-01-04: gradle 6.8-rc-5 available on SDKMAN!
================================================================================

Downloading: java 11.0.9.hs-adpt

In progress...

################################################################################################################################ 100.0%################################################################################################################################ 100.0%

Repackaging Java 11.0.9.hs-adpt...

Done repackaging...
rm: remove regular file '/home/vscode/.sdkman/tmp/java-11.0.9.hs-adpt.bin'? y

Installing: java 11.0.9.hs-adpt
Done installing!


Setting java 11.0.9.hs-adpt as default.

But I think this might actually be part of the package hook script rather than the sdk cli. Anyway, I believe adding -f to the rm is always good to prevent such thing.

[marc0der]

What you are seeing here is the effect of a hook served by the sdkman-hooks service. Please feel free to check that out and raise a PR there.

It would be super helpful to know why it is failing in the first place. Could you please provide your system details, like OS, shell version, and any zsh framework that you are using? My suspicion is that you are using a zsh framework that is messing with the default zsh settings, as an rm without -f should never be blocked from deleting something under normal condidtions.

[felipecrs]

❯ command -v rm
alias rm='rm -i'

It's not set in my dotfiles, so it must come from some of the extensions, such as OhMyZsh. But it does not matter, the thing is: always use rm -f in scripts to make sure it will work for everyone.

[felipecrs]

Found it: https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/common-aliases#file-handling

[smola]

This is also a common alias in bash. Amazon Linux 2 comes with it by default for the root user.

[marc0der]

@felipecrs thanks for contributing!