Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get set reversibility #158

Merged
merged 2 commits into from
Jan 30, 2019
Merged

Fix get set reversibility #158

merged 2 commits into from
Jan 30, 2019

Conversation

okhwaja
Copy link
Contributor

@okhwaja okhwaja commented Jan 30, 2019

Related to this issue: #157

Right now, the mock redis SET converts the key to a string but the GET method does not.

  • This PR adds the conversion into the GET method and adds an another assertion to the current test that was supposed to catch this.
  • This also adds a fix to the xadd tests where the keys were getting set without the prefix mock-redis-test:, so that multiple runs of the test suite were failing

Please let me know if you'd like any adjustments

@sds sds merged commit 96492cf into sds:master Jan 30, 2019
@sds sds added the bug label Jan 30, 2019
@sds sds mentioned this pull request Jan 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@okhwaja @sds