Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get set reversibility #158

Merged
merged 2 commits into from
Jan 30, 2019
Merged

Fix get set reversibility #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f65d8ac
prefix keys with mock-redis-test to ensure cleared between runs
okhwaja Jan 30, 2019
5f875b0
test for string conversion in get method
okhwaja Jan 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/mock_redis/string_methods.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ def decrby(key, n)
end

def get(key)
key = key.to_s
assert_stringy(key)
data[key]
end
Expand Down
1 change: 1 addition & 0 deletions spec/commands/get_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

@redises.set(key, 'hello')
@redises.get(key.to_s).should == 'hello'
@redises.get(key).should == 'hello'
end

it_should_behave_like 'a string-only command'
Expand Down
4 changes: 2 additions & 2 deletions spec/commands/xadd_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
end

it 'raises exception if id of 0 is added to an empty stream' do
expect { @redises.xadd('unknown-stream', { key: 'value' }, id: '0') }
expect { @redises.xadd('mock-redis-test:unknown-stream', { key: 'value' }, id: '0') }
.to raise_error(
Redis::CommandError,
'ERR The ID specified in XADD is equal or smaller than the target ' \
Expand All @@ -58,7 +58,7 @@
end

it 'does not raise exception on empty stream with id of 0 and positive sequence number' do
expect { @redises.xadd('unknown-stream', { key: 'value' }, id: '0-1') }
expect { @redises.xadd('mock-redis-test:unknown-stream', { key: 'value' }, id: '0-1') }
.to_not raise_error
end

Expand Down