Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition from using setup.py to pyroject.toml to specify project metadata #379

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

frances-h
Copy link
Contributor

CU-86azg18at
Resolve #376

@sdv-team
Copy link
Contributor

sdv-team commented Mar 1, 2024

@frances-h frances-h changed the title setup.py -> pyproject.toml Transition from using setup.py to pyroject.toml to specify project metadata Mar 1, 2024
Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left 1 optional comment

pyproject.toml Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.87%. Comparing base (ddc6889) to head (ee1aaa8).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   86.87%   86.87%           
=======================================
  Files          27       27           
  Lines        1791     1791           
=======================================
  Hits         1556     1556           
  Misses        235      235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frances-h frances-h marked this pull request as ready for review March 1, 2024 18:04
@frances-h frances-h requested a review from a team as a code owner March 1, 2024 18:04
Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frances-h frances-h merged commit 0c42168 into main Mar 1, 2024
61 checks passed
@frances-h frances-h deleted the issue-376-pyproject-toml branch March 1, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition from using setup.py to pyroject.toml to specify project metadata
5 participants