Update missing_value_replacement default
#577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
commented
Nov 2, 2022
| @@ -13,24 +13,13 @@ | |||
| 'missing_value_replacement': -1, | |||
| 'model_missing_values': True | |||
| }, | |||
| 'DatetimeTransformer': { | |||
| 'missing_value_replacement': 'mean', | |||
| 'UnixTimestampEncoder': { | |||
There was a problem hiding this comment.
Unrelated change: I think we just forgot to remove these when we renamed the transformers.
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## issue-533-removal-.value #577 +/- ##
==========================================================
Coverage 100.00% 100.00%
==========================================================
Files 17 17
Lines 1482 1440 -42
==========================================================
- Hits 1482 1440 -42
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fealho
requested review from
pvk-developer and
amontanez24
and removed request for
a team
amontanez24
approved these changes
Nov 4, 2022
| @@ -362,7 +290,7 @@ def test_is_generator(self): | |||
| ``IS_GENERATOR`` is set to ``True``. | |||
|
|
|||
| Output: | |||
| - the boolean value stored in ``COMPOSITION_IS_IDENTITY``. | |||
| - the boolean value stored in ``IS_GENERATOR``. | |||
fealho
force-pushed
the
issue-576-update-defaults
branch
from
55b0fcf
to
040481e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #576.