Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add add-on detection for transformers #647

Merged
merged 9 commits into from
May 25, 2023
Merged

Conversation

frances-h
Copy link
Contributor

@frances-h frances-h commented May 17, 2023

Resolve #646

@frances-h frances-h requested a review from a team as a code owner May 17, 2023 15:46
@frances-h frances-h requested review from pvk-developer and fealho and removed request for a team May 17, 2023 15:46
@frances-h frances-h marked this pull request as draft May 17, 2023 15:48
@frances-h frances-h marked this pull request as ready for review May 17, 2023 16:08
@frances-h frances-h marked this pull request as draft May 17, 2023 18:12
@frances-h frances-h marked this pull request as ready for review May 22, 2023 01:21
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f9f0f3d) 100.00% compared to head (6672a78) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #647   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        17    -1     
  Lines         1573      1600   +27     
=========================================
+ Hits          1573      1600   +27     
Impacted Files Coverage Δ
rdt/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

rdt/__init__.py Outdated Show resolved Hide resolved
rdt/__init__.py Outdated Show resolved Hide resolved
rdt/__init__.py Outdated Show resolved Hide resolved
tests/unit/test___init__.py Outdated Show resolved Hide resolved
tests/unit/test___init__.py Outdated Show resolved Hide resolved
@frances-h frances-h force-pushed the transformer-addon-detection branch from da37d16 to bf8de2e Compare May 23, 2023 14:32
@frances-h frances-h force-pushed the transformer-addon-detection branch from bf8de2e to 52a0fc9 Compare May 23, 2023 14:35
Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing the comments!

Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After you fix lint, :shipit:

@frances-h frances-h merged commit 7d97109 into master May 25, 2023
@frances-h frances-h deleted the transformer-addon-detection branch May 25, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add add-on detection for premium transformers
4 participants