Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce sampled values by model in range [0,1] for categorical data. #81

Closed
ManuelAlvarezC opened this issue Jan 30, 2019 · 0 comments · Fixed by #87
Closed

Enforce sampled values by model in range [0,1] for categorical data. #81

ManuelAlvarezC opened this issue Jan 30, 2019 · 0 comments · Fixed by #87
Assignees
@ManuelAlvarezC
Labels
internal The issue doesn't change the API or functionality
Milestone
0.1.1

Comments

@ManuelAlvarezC
Copy link
Contributor

Fields that are labeled as categorical in the metadata, will be transformed using rdt.transformers.CatTransformer, that maps the set of categories into the interval [0, 1].

That means that when fitting the model, all the values for the given column are in such range, however, when sampling, the sampling values aren't always located in that interval, and are ignored by the categorical transformer and returned unchanged.
@ManuelAlvarezC ManuelAlvarezC added the internal The issue doesn't change the API or functionality label Jan 30, 2019
@ManuelAlvarezC ManuelAlvarezC added this to the 0.1.1 milestone Jan 30, 2019
@ManuelAlvarezC ManuelAlvarezC self-assigned this Jan 30, 2019
@ManuelAlvarezC ManuelAlvarezC mentioned this issue Feb 5, 2019
Merged
JonathanDZiegler pushed a commit to JonathanDZiegler/SDV that referenced this issue Feb 7, 2022
@fealho
Merge pull request sdv-dev#81 from sdv-dev/nan-loss
b80e6e5 
Nan loss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManuelAlvarezC ManuelAlvarezC

Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
0.1.1
Development

Successfully merging a pull request may close this issue.

Issue 81: enforce sampled values in range [0,1] for categorical columns sdv-dev/SDV
1 participant
@ManuelAlvarezC