Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 81: enforce sampled values in range [0,1] for categorical columns #87

Merged
merged 8 commits into from
Feb 13, 2019

Conversation

ManuelAlvarezC
Copy link
Contributor

A method for rescaling values into the range [0, 1] in the case some are sampled out of it. These changes should fix the bug where some times, when sampling categorical values, numbers are returned on some rows instead of the expected categories.

Resolves #81

@ManuelAlvarezC ManuelAlvarezC added the internal The issue doesn't change the API or functionality label Feb 5, 2019
sdv/sampler.py Outdated Show resolved Hide resolved
sdv/sampler.py Outdated Show resolved Hide resolved
sdv/sampler.py Outdated Show resolved Hide resolved
Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment about the double underscore, the PR looks good to me.

sdv/sampler.py Outdated Show resolved Hide resolved
@ManuelAlvarezC ManuelAlvarezC merged commit b688a88 into master Feb 13, 2019
@ManuelAlvarezC ManuelAlvarezC deleted the 81_enforce_sampled_values_categorical branch February 13, 2019 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce sampled values by model in range [0,1] for categorical data.
2 participants