Fix KeyError in CTGANSynthesizer when applying constraints
#1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvk-developer
requested review from
lajohn4747 and
amontanez24
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1718 +/- ##
=======================================
Coverage 97.08% 97.08%
=======================================
Files 48 48
Lines 4489 4489
=======================================
Hits 4358 4358
Misses 131 131 ☔ View full report in Codecov by Sentry. |
amontanez24
approved these changes
Dec 13, 2023
lajohn4747
reviewed
Dec 13, 2023
| @@ -154,7 +154,7 @@ def _estimate_num_columns(self, data): | |||
| num_generated_columns[column] = 11 | |||
|
|
|||
| elif sdtypes[column] in {'categorical', 'boolean'}: | |||
| if transformers[column] is None: | |||
| if transformers.get(column) is None: | |||
There was a problem hiding this comment.
nit: Can we do transformers.get(column, None) so it's explicit?
There was a problem hiding this comment.
python always returns None.
lajohn4747
reviewed
Dec 13, 2023
pvk-developer
deleted the
issue-1717-KeyError-in-CTGANSynthesizer-when-applying-constraints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86ayw5zbe
Resolves #1717