Include validation check for single table auto_assign_transformers #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvk-developer
previously approved these changes
May 22, 2024
Yes it does, I added a test to multitable to confirm it as well. Multitable synthesizer handles |
R-Palazzo
reviewed
May 22, 2024
R-Palazzo
reviewed
May 22, 2024
lajohn4747
commented
May 22, 2024
| @@ -32,7 +32,7 @@ def get_metadata(self, add_sequence_key=True, add_sequence_index=False): | |||
|
|
|||
| def get_data(self): | |||
| data = pd.DataFrame({ | |||
| 'time': [1, 2, 3], | |||
There was a problem hiding this comment.
I actually use datetimes as now auto_assign_transformer will validate this data which would error out. It should be date-time anyway
R-Palazzo
approved these changes
May 22, 2024
lajohn4747
requested review from
amontanez24 and
pvk-developer
and removed request for
pvk-developer
amontanez24
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1509
CU-85ztjjzrw
Include better messsaging for auto_assign_transformers by checking metadata and data before going through assigning the transformers.