[Revised] Adding MarkBind as an alternative docs option #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Click here to submit a new iteration when this PR is ready for review. See this repository's contribution guide for more information. |
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
=========================================
Coverage 75.26% 75.26%
Complexity 419 419
=========================================
Files 71 71
Lines 1338 1338
Branches 126 126
=========================================
Hits 1007 1007
Misses 301 301
Partials 30 30 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8 tasks
|
@tlylt can have a look? |
tlylt
reviewed
Sep 11, 2023
.github/workflows/docs.yml
Outdated
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| rootDirectory: './docs' | ||
| baseUrl: '/addressbook-level3' # replace with your repo name | ||
| version: '^5.0.2' |
There was a problem hiding this comment.
Suggested change
| version: '^5.0.2' | |
| version: '^5.1.0' |
Other than the above, LGTM! |
damithc
force-pushed
the
switch-docs-to-markbind
branch
from
d39eadb
to
da647a3
Compare
damithc
pushed a commit
to damithc/ab3-markbind
that referenced
this pull request
Sep 11, 2023
Let's migrate the docs site from Jekyll to MarkBind. Primary author: @tlylt in se-edu/addressbook-level3/pull/156 Further tweaks: @damithc in se-edu/addressbook-level3/pull/206 (cherry picked from commit da647a31d3f265287dbaf3cac6adc8a7272be68c)
This was referenced Sep 16, 2023
This was referenced Sep 17, 2023
This was referenced Sep 18, 2023
This was referenced Sep 23, 2023
lihongguang00
pushed a commit
to lihongguang00/tp
that referenced
this pull request
Oct 14, 2023
Let's migrate the docs site from Jekyll to MarkBind. Primary author: @tlylt in se-edu/addressbook-level3/pull/156 Further tweaks: @damithc in se-edu/addressbook-level3/pull/206
This was referenced Oct 27, 2023
damithc
pushed a commit
that referenced
this pull request
Feb 9, 2024
xuelinglow
pushed a commit
to xuelinglow/tp
that referenced
this pull request
Feb 26, 2024
Let's migrate the docs site from Jekyll to MarkBind. Primary author: @tlylt in se-edu/addressbook-level3/pull/156 Further tweaks: @damithc in se-edu/addressbook-level3/pull/206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A revised version based on #156
Once finalized, all commits will be squashed to one commit and the commit message will mention #156 as the primary source of changes
Deployed site https://damithc.github.io/ab3-markbind/index.html