libsel4simple-default,riscv: implement irq_trigger #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @canarysnort01, I've been stuck on this timer driver for a while as I could not get it enabled. I revisited it briefly last week and managed to patch U-Boot such that it turns on the timers and now getting the time works. I haven't spent much time on it since, feel free to email me ( U-Boot patch is here by the way Ivan-Velickovic/u-boot@f524a32. |
canarysnort01
force-pushed
the
riscv-simple-irq-trigger
branch
from
3120480
to
69d3eb6
Compare
Ivan-Velickovic
approved these changes
Aug 22, 2023
|
Can this be merged? |
Wire up simple->irq_trigger to seL4_IRQControl_GetTrigger on risc-v. This allows risc-v drivers in libplatsupport to register edge-triggered interrupts. Signed-off-by: Jimmy Brush <code@jimmah.com>
Signed-off-by: Jimmy Brush <code@jimmah.com>
Ivan-Velickovic
force-pushed
the
riscv-simple-irq-trigger
branch
from
7fb680e
to
a3a136f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire up simple->irq_trigger to seL4_IRQControl_GetTrigger on risc-v. This allows risc-v drivers in libplatsupport to register edge-triggered interrupts.
Purpose: Ready to merge
Context: Needed for the star64 timer driver that will be in libplatsupport
Testing performed: Tested on a WIP version of sel4test for the star64 platform on pinetab-v hardware