fix: patches from kent #99
Conversation
ridale
force-pushed
the
fix/kent-patches
branch
from
9338d91
to
5c9c756
Compare
| @@ -14,11 +14,11 @@ | |||
|
|
|||
| struct enet *get_enet_from_driver(struct eth_driver *driver); | |||
|
|
|||
| enum { | |||
| enum nic_config_flags_t { | |||
There was a problem hiding this comment.
This changes nic_config_flags_t from a global with an enum type to a enum type declaration. Recent compiler versions (gcc-10) no longer place the global definitions in a COM section and this leads to linker errors. Alternatively this could be changed a different way to add a typedef at the start.
There was a problem hiding this comment.
I think the typedef is what we need here, this was never supposed to be a global variable.
There was a problem hiding this comment.
issue looks similar to seL4/camkes-vm#13
ridale
force-pushed
the
fix/kent-patches
branch
from
5c9c756
to
3f9fa45
Compare
Signed-off-by: ridale <ridale123@outlook.com> fix: patches from kent, imx8mq evk. Signed-off-by: ridale <ridale123@outlook.com>
ridale
force-pushed
the
fix/kent-patches
branch
from
8305df1
to
fcc3307
Compare
|
Converting these PRs to draft for now as they're currently the minimum set of changes to run Ethdrivers on imx8mq-evk but aren't necessarily safe to merge due to impacts on behavior of other platforms. |
|
This PR can now be reviewed to be the next to get merged. Make sure there are at least 2 approvals before merging. |
1 similar comment
|
This PR can now be reviewed to be the next to get merged. Make sure there are at least 2 approvals before merging. |
|
This PR can now be reviewed to be the next to get merged. Make sure there are at least 2 approvals before merging. |
2 similar comments
|
This PR can now be reviewed to be the next to get merged. Make sure there are at least 2 approvals before merging. |
|
This PR can now be reviewed to be the next to get merged. Make sure there are at least 2 approvals before merging. |
paired with patch in global components.