Enable Ctrl+C to stop the GUI #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-bass
commented
Feb 4, 2023
setup/create_python_env.bash
Outdated
| pip install lark pytest pytest-dependency pytest-html wheel | ||
| pip install catkin-pkg empy lark pytest pytest-dependency pytest-html wheel |
There was a problem hiding this comment.
snuck this in because it helps resolve some weird colcon build issues
There was a problem hiding this comment.
What the heck, catkin? That's really weird
There was a problem hiding this comment.
Can you at least leave a comment with a link to where you found this?
|
In testing, it does kill the GUI with Ctrl+C 👍 but I get this error, too: python3 examples/demo.py --> Is that new? Edit: I also get |
|
I'll push a comment about catkin-pkg then merge this. |
AndyZe
approved these changes
Feb 5, 2023
|
The catkin thing is because it's actually used by colcon! See e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also helps address #64.
Now any program that uses the GUI will terminate correctly when Ctrl+C is pressed. I also realized I was duplicating code to start the GUI and moved it to a utility.