Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exact "objectsid" match use "=" comparison instead of "starts with" #10

Closed
wants to merge 1 commit into from
Closed

Exact "objectsid" match use "=" comparison instead of "starts with" #10

wants to merge 1 commit into from

Conversation

cnotin
Copy link
Collaborator

@cnotin cnotin commented Jan 9, 2020 •
edited

It's only a cosmetic change. I tested it and the results are the same.

@seajaysec
Copy link
Owner

I like this, along with your other PR's (#11 and #12) for the same search. Could you add a request that includes each of the changes? I'll merge that in.

@cnotin
Copy link
Collaborator Author

cnotin commented Jan 12, 2020

Thanks for the feedback! I thought separate PRs were better but I can submit a single one too!

@cnotin
Copy link
Collaborator Author

cnotin commented Jan 17, 2020

Aggregated in #13

@cnotin cnotin closed this Jan 17, 2020
@cnotin cnotin deleted the patch-1 branch January 17, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cnotin @seajaysec