Use through to simplify

sealink · Mar 28, 2018 · 297fda9 · 297fda9
1 parent 75034f4
commit 297fda9
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/lib/right_on/role_model.rb b/lib/right_on/role_model.rb
@@ -3,20 +3,13 @@ module RoleModel
     def self.included(base)
       base.module_eval do
         has_and_belongs_to_many :roles, class_name: 'RightOn::Role'
+        has_many :rights, through: :roles, class_name: 'RightOn::Right'
       end
       Role.module_eval do
         has_and_belongs_to_many base.table_name.to_sym, dependent: :restrict
       end
     end
 
-    def rights
-      @rights ||=
-        Right
-          .select('distinct rights.*')
-          .joins(:roles)
-          .where('rights_roles.role_id IN (?)', role_ids)
-    end
-
     def has_privileges_of?(other_user)
       (other_user.rights - rights).empty?
     end