This repository has been archived by the owner on Jan 4, 2021. It is now read-only.
Extract rights_yaml to where it is used (in ByGroups) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 6, 2018
lib/right_on/by_group.rb
Outdated
| .each { |r| r.group = group } | ||
| end | ||
| def yaml_rights | ||
| YAML::load_file(RightOn.rights_yaml)['rights'] |
There was a problem hiding this comment.
Style/ColonMethodCall: Do not use :: for method calls.
| rights.group_by(&:group) | ||
| yaml_rights.each_pair.with_object({}) do |(group, right_names), hash| | ||
| hash[group] = right_names | ||
| .flat_map { |right_name| right_name_to_rights(right_name) } |
There was a problem hiding this comment.
Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Align .flat_map with right_names on line 13.
HellRok
approved these changes
Apr 8, 2018
alvinypyim
approved these changes
Apr 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify ByGroup code, no need to make 'group' an accessor since it's virtual, just calculate that in the task.
Coverage had to be dropped as lines removed (actual coverage is the same). This is due to untested controller code which I plan to put in cancanright.