This repository has been archived by the owner on Jan 4, 2021. It is now read-only.
Final right on clean #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mnoack
commented
Apr 13, 2018
mnoack
commented
- Some missing requires
- Improve error handling in ByGroup
- Merging the controller extensions
- Minor fixes
* One was cancanright's other was right_on's, both depended on each other
houndci-bot
reviewed
Apr 13, 2018
| end | ||
|
|
||
| format.json do | ||
| render status: :unauthorized, json: @permission_denied_response.to_json |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [81/80]
| format.html do | ||
| render status: :unauthorized, | ||
| template: 'permission_denied', | ||
| layout: ( permission_denied_layout || false ) |
There was a problem hiding this comment.
Layout/SpaceInsideParens: Space inside parentheses detected.
| end | ||
|
|
||
| def rescue_access_denied(exception) | ||
| @permission_denied_response = RightOn::PermissionDeniedResponse.new(params, controller_action_options) |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [108/80]
| can? :access, [params[:controller], params[:action]].join('#') | ||
| end | ||
|
|
||
| def rescue_access_denied(exception) |
There was a problem hiding this comment.
Lint/UnusedMethodArgument: Unused method argument - exception. If it's necessary, use _ or _exception as an argument name to indicate that it won't be used. You can also write as rescue_access_denied(*) if you want the method to accept any arguments but don't care about them.
| @@ -10,14 +19,34 @@ def authorize_action! | |||
| end | |||
|
|
|||
| def can_access_controller_action?(controller, action) | |||
| (can?(:access, controller) && !Right.where(subject: controller + '#' + action).exists?) || | |||
| (can?(:access, controller) && !Right.where(ccr_subject: controller + '#' + action).exists?) || | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [100/80]
| @@ -42,7 +42,9 @@ def action_rights(controller, actions) | |||
| end | |||
|
|
|||
| def rights_by_name!(name) | |||
| @rights_by_name[name] or fail name.inspect | |||
| @rights_by_name[name] or fail RightOn::RightNotFound, name.inspect | |||
There was a problem hiding this comment.
Style/AndOr: Use || instead of or.
4 similar comments
HellRok
approved these changes
Apr 13, 2018
Steffylicious
approved these changes
Apr 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.