Improve by group #9

mnoack · 2018-03-28T07:22:05Z

Just some cleanups in preparation for breaking changes

* Allows us to split ByGroup later

houndci-bot · 2018-03-28T07:22:14Z

spec/support/bootstrap.rb

+      models:        RightOn::Right.create!(name: 'models',        controller: 'models'),
+      models_index:  RightOn::Right.create!(name: 'models#index',  controller: 'models', action: 'index'),
+      models_change: RightOn::Right.create!(name: 'models#change', controller: 'models', action: 'change'),
+      models_view:   RightOn::Right.create!(name: 'models#view',   controller: 'models', action: 'view')


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Line is too long. [104/80]

houndci-bot · 2018-03-28T07:22:14Z

spec/support/bootstrap.rb

+      users:         RightOn::Right.create!(name: 'users',         controller: 'users'),
+      models:        RightOn::Right.create!(name: 'models',        controller: 'models'),
+      models_index:  RightOn::Right.create!(name: 'models#index',  controller: 'models', action: 'index'),
+      models_change: RightOn::Right.create!(name: 'models#change', controller: 'models', action: 'change'),


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Line is too long. [107/80]

houndci-bot · 2018-03-28T07:22:14Z

spec/support/bootstrap.rb

+    {
+      users:         RightOn::Right.create!(name: 'users',         controller: 'users'),
+      models:        RightOn::Right.create!(name: 'models',        controller: 'models'),
+      models_index:  RightOn::Right.create!(name: 'models#index',  controller: 'models', action: 'index'),


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Line is too long. [106/80]

houndci-bot · 2018-03-28T07:22:14Z

spec/support/bootstrap.rb

+    RightOn::Right.delete_all
+    {
+      users:         RightOn::Right.create!(name: 'users',         controller: 'users'),
+      models:        RightOn::Right.create!(name: 'models',        controller: 'models'),


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Line is too long. [89/80]

houndci-bot · 2018-03-28T07:22:14Z

spec/support/bootstrap.rb

+  def self.various_rights_with_actions
+    RightOn::Right.delete_all
+    {
+      users:         RightOn::Right.create!(name: 'users',         controller: 'users'),


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Line is too long. [88/80]

houndci-bot · 2018-03-28T07:22:15Z

spec/right_on_spec.rb

-    expect(@users.allowed?(:controller => 'users', :action => 'index')).to eq true
-    expect(@users.allowed?(:controller => 'users', :action => 'edit' )).to eq true
-    expect(@users.allowed?(:controller => 'users', :action => 'hello')).to eq true
+    expect(users.allowed?(:controller => 'users', :action => 'index')).to eq true


Use the new Ruby 1.9 hash syntax.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Line is too long. [81/80]

houndci-bot · 2018-03-28T07:22:15Z

spec/right_on_spec.rb

-      'admin' => [@users]
-    )
+    expect(other.sensible_name).to eq 'Models'
+    expect(index.sensible_name).to eq 'Models - Index'


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-03-28T07:22:15Z

spec/right_on_spec.rb

-      'general' => [@other, @index, @view, @change],
-      'admin' => [@users]
-    )
+    expect(other.sensible_name).to eq 'Models'


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-03-28T07:22:15Z

spec/right_on_spec.rb

-    expect(@index.sensible_name).to eq 'Models - Index'
-  end
+    expect(other.to_s).to eq 'models'
+    expect(index.to_s).to eq 'models#index'


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-03-28T07:22:15Z

spec/right_on_spec.rb

-    expect(@other.sensible_name).to eq 'Models'
-    expect(@index.sensible_name).to eq 'Models - Index'
-  end
+    expect(other.to_s).to eq 'models'


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

coveralls · 2018-03-28T07:27:58Z

Coverage remained the same at 91.72% when pulling 62eca49 on improve-by-group into 0beba65 on master.

coveralls · 2018-03-28T07:27:58Z

Coverage remained the same at 91.72% when pulling 62eca49 on improve-by-group into 0beba65 on master.

coveralls · 2018-03-28T07:27:58Z

Coverage increased (+0.1%) to 91.875% when pulling fbad116 on improve-by-group into 7a1749f on master.

* master: Release the hounds! (support single quotes) Test against newer ruby versions Use through to simplify Apply same logic for long line above Handle long line and add test to ensure this works Remove duplicate specs Remove rails 4 support due to change [TT-3352] Ensure roles currently in use cannot be deleted # Conflicts: # CHANGELOG.md

houndci-bot · 2018-04-06T05:32:21Z

spec/support/bootstrap.rb

+      models:        RightOn::Right.create!(name: 'models',        controller: 'models'),
+      models_index:  RightOn::Right.create!(name: 'models#index',  controller: 'models', action: 'index'),
+      models_change: RightOn::Right.create!(name: 'models#change', controller: 'models', action: 'change'),
+      models_view:   RightOn::Right.create!(name: 'models#view',   controller: 'models', action: 'view')


Metrics/LineLength: Line is too long. [104/80]

houndci-bot · 2018-04-06T05:32:21Z

spec/support/bootstrap.rb

+      users:         RightOn::Right.create!(name: 'users',         controller: 'users'),
+      models:        RightOn::Right.create!(name: 'models',        controller: 'models'),
+      models_index:  RightOn::Right.create!(name: 'models#index',  controller: 'models', action: 'index'),
+      models_change: RightOn::Right.create!(name: 'models#change', controller: 'models', action: 'change'),


Metrics/LineLength: Line is too long. [107/80]

houndci-bot · 2018-04-06T05:32:21Z

spec/support/bootstrap.rb

+    {
+      users:         RightOn::Right.create!(name: 'users',         controller: 'users'),
+      models:        RightOn::Right.create!(name: 'models',        controller: 'models'),
+      models_index:  RightOn::Right.create!(name: 'models#index',  controller: 'models', action: 'index'),


Metrics/LineLength: Line is too long. [106/80]

houndci-bot · 2018-04-06T05:32:21Z

spec/support/bootstrap.rb

+    RightOn::Right.delete_all
+    {
+      users:         RightOn::Right.create!(name: 'users',         controller: 'users'),
+      models:        RightOn::Right.create!(name: 'models',        controller: 'models'),


Metrics/LineLength: Line is too long. [89/80]

houndci-bot · 2018-04-06T05:32:21Z

spec/support/bootstrap.rb

+  def self.various_rights_with_actions
+    RightOn::Right.delete_all
+    {
+      users:         RightOn::Right.create!(name: 'users',         controller: 'users'),


Metrics/LineLength: Line is too long. [88/80]

houndci-bot · 2018-04-06T05:32:22Z

spec/right_on_spec.rb

-    expect(@other.allowed?(edit_action )).to eq false # as specific action exists
-    expect(@other.allowed?(hello_action)).to eq true # as hello isn't defined
+    expect(other.allowed?(index_action)).to eq false # as specific action exists
+    expect(other.allowed?(edit_action )).to eq false # as specific action exists


Layout/SpaceInsideParens: Space inside parentheses detected.

houndci-bot · 2018-04-06T05:32:22Z

spec/right_on_spec.rb

-    expect(@users.allowed?(:controller => 'users', :action => 'hello')).to eq true
+    expect(users.allowed?(:controller => 'users', :action => 'index')).to eq true
+    expect(users.allowed?(:controller => 'users', :action => 'edit' )).to eq true
+    expect(users.allowed?(:controller => 'users', :action => 'hello')).to eq true


Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Metrics/LineLength: Line is too long. [81/80]

houndci-bot · 2018-04-06T05:32:22Z

spec/right_on_spec.rb

-    expect(@users.allowed?(:controller => 'users', :action => 'edit' )).to eq true
-    expect(@users.allowed?(:controller => 'users', :action => 'hello')).to eq true
+    expect(users.allowed?(:controller => 'users', :action => 'index')).to eq true
+    expect(users.allowed?(:controller => 'users', :action => 'edit' )).to eq true


Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Layout/SpaceInsideParens: Space inside parentheses detected.
Metrics/LineLength: Line is too long. [81/80]

houndci-bot · 2018-04-06T05:32:22Z

spec/right_on_spec.rb

-    expect(@users.allowed?(:controller => 'users', :action => 'index')).to eq true
-    expect(@users.allowed?(:controller => 'users', :action => 'edit' )).to eq true
-    expect(@users.allowed?(:controller => 'users', :action => 'hello')).to eq true
+    expect(users.allowed?(:controller => 'users', :action => 'index')).to eq true


Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Metrics/LineLength: Line is too long. [81/80]

houndci-bot · 2018-04-06T05:32:22Z

spec/by_group_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2018-04-06T05:54:06Z

spec/right_on_spec.rb

  before do
-    @new_right = RightOn::Right.new(:name => "tickets@destroy", :controller => "tickets", :action => "destroy")
+    @new_right = RightOn::Right.new(name: 'tickets@destroy', controller: 'tickets', action: 'destroy')


Metrics/LineLength: Line is too long. [102/80]

mnoack added 5 commits March 28, 2018 15:45

Remove unused code

a1a58e3

Extract common rights into bootstrap

f51d2c8

* Allows us to split ByGroup later

Extract ByGroup into it's own spec

689b0f8

Remove additional trailing white space

f0ee045

Changelog

62eca49

houndci-bot reviewed Mar 28, 2018

View reviewed changes

alvinypyim approved these changes Mar 28, 2018

View reviewed changes

jmortlock approved these changes Apr 5, 2018

View reviewed changes

houndci-bot reviewed Apr 6, 2018

View reviewed changes

Make the hound happier

b0fbb0d

houndci-bot reviewed Apr 6, 2018

View reviewed changes

Fix issue with Ruby 2.5

fbad116

mnoack merged commit a9a15e1 into master Apr 6, 2018

alvinypyim deleted the improve-by-group branch April 10, 2018 00:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve by group #9

Improve by group #9

mnoack commented Mar 28, 2018

houndci-bot Mar 28, 2018

houndci-bot Mar 28, 2018

houndci-bot Mar 28, 2018

houndci-bot Mar 28, 2018

houndci-bot Mar 28, 2018

houndci-bot Mar 28, 2018

houndci-bot Mar 28, 2018

houndci-bot Mar 28, 2018

houndci-bot Mar 28, 2018

houndci-bot Mar 28, 2018

coveralls commented Mar 28, 2018

coveralls commented Mar 28, 2018

coveralls commented Mar 28, 2018 •

edited

Loading

houndci-bot Apr 6, 2018

houndci-bot Apr 6, 2018

houndci-bot Apr 6, 2018

houndci-bot Apr 6, 2018

houndci-bot Apr 6, 2018

houndci-bot Apr 6, 2018

houndci-bot Apr 6, 2018

houndci-bot Apr 6, 2018

houndci-bot Apr 6, 2018

houndci-bot Apr 6, 2018

houndci-bot Apr 6, 2018

Improve by group #9

Improve by group #9

Conversation

mnoack commented Mar 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Mar 28, 2018

coveralls commented Mar 28, 2018

coveralls commented Mar 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Mar 28, 2018 •

edited

Loading