Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move api-clients to api (redirects only) #321

Merged
merged 32 commits into from
Aug 29, 2024
Merged

Move api-clients to api (redirects only) #321

merged 32 commits into from
Aug 29, 2024

Conversation

razor-x
Copy link
Contributor

@razor-x razor-x commented Aug 27, 2024

This PR moves all urls under /api-clients to /api using the new API matching route structure. It adds redirects for all pages that were moved and updates a few links where needed, but leaves the rest alone for another PR (links will all work due to the redirects).

Verified that all existing files got a redirect expect for these which didn't move:

  • docs/api-clients/authentication.md
  • docs/api-clients/installation.md
  • docs/api-clients/overview.md
  • docs/api-clients/devices/README.md
  • docs/api-clients/events/README.md
  • docs/api-clients/locks/README.md
  • docs/api-clients/workspaces/README.md

Verified that all redirect targets exist.

@razor-x razor-x requested a review from sybohy August 27, 2024 22:45
@razor-x
Copy link
Contributor Author

razor-x commented Aug 27, 2024

Just need to fix links in the summary pointing at /api/access_codes/unmanaged-access-codes and /api/devices/unmanaged-devices.

@razor-x
Copy link
Contributor Author

razor-x commented Aug 27, 2024

All links are working/correct now in the nav.

@razor-x
Copy link
Contributor Author

razor-x commented Aug 27, 2024

The redirects work, but they don't fix links that point to the old references when the link ends in .md, and this does not work: a44ca44 (#321)

Going to try to just remove the .md extension from the links to the api-clients so they use the redirects.

We will eventually remove all references to api-clients so this is just a workaround until then.

@razor-x razor-x merged commit c0c97c4 into main Aug 29, 2024
6 checks passed
@razor-x razor-x deleted the move-api-ref-urls branch August 29, 2024 00:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants