Add the Data files needed for Windows to work properly. #63
Conversation
These files will be incluuded in the Windows setup package. The climatology data will be installed and ready to be used by climatology_pi as soon as climatology_pi-1.4.1-ov50-win32.exe finishes installing the plugin. This eliminates the need for downloading the data from some other site.
Add climatology files to data folder.
|
I cannot allow binary files this size into git If I have a slow connection and want to clone in the future, it will have to download every version of every binary file to get a full repository. Git clone cannot resume timeouts making this worse. Notice all my plugins clone quick even will full history and OpenCPN is impossible for me to clone unless I have a good connection (I usually have unreliable) In my opinion, OpenCPN should be rebased without any binary data. So, you need to download the data files separate. The code itself is meant to do this automatically but it's been claimed it's broken. Alternately a script or it could even be built into the build system, but not dumped in git, sorry. |
|
Make it a git submodule (which you yourself do not have to clone in case you don't have good enough connection) if you are concerned about the size of this very repository. |
|
Ok, as I said earlier, we need to fix the automatic binary file download and file decompression. Pavel got this working in another plugin I think, Don't remember which one right now. |
Sean Windows downloads of the data files are not working properly, therefore Paul added the data files back into the code.
You don't need the fix for Wind Rose font size because you have merged it,ClimatologyOverlayFactory.cpp change . This compiles and works fine but there is an error code on appeveyor, however I used the file created and tested it.
Please see
#52 (comment)
Can we fix the windows download of the data files so the binary data files are not needed in the exe?