Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect timeout for multiple IPs #1940

Merged

Conversation

conradludgate
Copy link
Contributor

fixes #1939 and adds a regression test

@conradludgate
Copy link
Contributor Author

conradludgate commented Aug 13, 2023

Recent tokio release 1.30 bumped MSRV to 1.63 which seems to be breaking the MSRV checks.

@conradludgate
Copy link
Contributor Author

In my local testing, tempfile also needs to be fixed to 3.6.0 to downgrade the rustix version, but 3.7.0 was released 3 weeks ago and I haven't seen that in any CI failures here, so I'm not sure if it's relevant

@seanmonstar
Copy link
Owner

No problem, I just bumped MSRV in #1947.

@seanmonstar seanmonstar merged commit 2a881fb into seanmonstar:master Oct 2, 2023
31 checks passed
kodiakhq bot pushed a commit to pdylanross/fatigue that referenced this pull request Oct 3, 2023
Bumps reqwest from 0.11.20 to 0.11.21.

Release notes
Sourced from reqwest's releases.

v0.11.21
What's Changed

Add automatically detecting macOS proxy settings.
Add ClientBuilder::tls_info(bool), which will put tls::TlsInfo into the response extensions.
Fix trust-dns resolver from possible hangs.
Fix connect timeout to be split among multiple IP addresses.

New Contributors

@​SpeedReach made their first contribution in seanmonstar/reqwest#1960
@​jefflloyd made their first contribution in seanmonstar/reqwest#1955
@​droe made their first contribution in seanmonstar/reqwest#1938
@​conradludgate made their first contribution in seanmonstar/reqwest#1940




Changelog
Sourced from reqwest's changelog.

v0.11.21

Add automatically detecting macOS proxy settings.
Add ClientBuilder::tls_info(bool), which will put tls::TlsInfo into the response extensions.
Fix trust-dns resolver from possible hangs.
Fix connect timeout to be split among multiple IP addresses.




Commits

d050e60 v0.11.21
2a881fb fix: split connect timeout for multiple IPs (#1940)
17c893f Bump actions/checkout from 3 to 4 (#1968)
10d9d23 Add tls_info / TlsInfo for access to peer's leaf certificate (#1938)
d3d95a5 Optimize TrustDnsResolver (#1967)
0292486 dep: Upgrade trust-dns-resolver from v0.22 to v0.23 (#1965)
70d100c Feature: auto detect MacOS proxy settings (#1955)
34f6c70 Added wasm in the docs. (#1960)
See full diff in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connect_timeout does not respect multiple IP addresses
2 participants