Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable rustls #701

Closed
wants to merge 11 commits into from
Closed

Re-enable rustls #701

wants to merge 11 commits into from

Conversation

MaikKlein
Copy link

@MaikKlein MaikKlein commented Nov 5, 2019 •
edited

I realized today that the latest version of reqwest only supports openssl.

I updated the dependencies and fixed a few build errors and the test cases are passing.

@MaikKlein MaikKlein mentioned this pull request Nov 5, 2019
Open
26 tasks
@Luro02 Luro02 mentioned this pull request Nov 8, 2019
Closed
@link2xt link2xt mentioned this pull request Nov 24, 2019
Closed
@yazgoo yazgoo mentioned this pull request Nov 26, 2019
Closed
@coltfred
Copy link

coltfred commented Dec 5, 2019

Is this PR waiting on something? Http2 support is missing entirely without this.

@seanmonstar
Copy link
Owner

I'd love to merge support for this, it's currently waiting on a hyper-rustls release to use hyper 0.13.

@glebpom
Copy link
Contributor

glebpom commented Dec 15, 2019

Please, take a look here: https://github.com/glebpom/reqwest/tree/rustls. There are conflict resolutions and adaptation of this branch for the latest master branch.

@Darkspirit Darkspirit mentioned this pull request Dec 17, 2019
Merged
@ctz
Copy link

ctz commented Dec 17, 2019

I'd love to merge support for this, it's currently waiting on a hyper-rustls release to use hyper 0.13.

This is ready: https://crates.io/crates/hyper-rustls/0.19.0 💯

alex
alex reviewed Dec 18, 2019
View reviewed changes
Copy link
Contributor

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
CryZe
CryZe suggested changes Dec 18, 2019
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@nickelc
Copy link
Contributor

nickelc commented Dec 18, 2019

This don't compile with the rustls feature enabled

@glebpom
Copy link
Contributor

glebpom commented Dec 18, 2019

@nickelc This is fixed here https://github.com/EmbarkStudios/reqwest/pull/1/files

@MaikKlein
Merge pull request #1 from glebpom/rustls
6ee1d59 
Merge latest upstream master and implement additional structures according to updates in master
@alex
Copy link
Contributor

alex commented Dec 18, 2019

I think this PR should probably also uncomment the rustls-tls bits from https://github.com/seanmonstar/reqwest/blob/master/.github/workflows/ci.yml

@seanmonstar
Copy link
Owner

Thanks so much! I don't know why CI isn't trigger for this, I'll fiddle around.

@seanmonstar seanmonstar mentioned this pull request Dec 19, 2019
Merged
@seanmonstar
Copy link
Owner

Merged in #747!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex alex alex left review comments

@CryZe CryZe CryZe requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@MaikKlein @coltfred @seanmonstar @glebpom @ctz @nickelc @alex @CryZe @repi