[pull] master from ros-tooling:master

.eslintrc.json

@@ -19,5 +19,6 @@
 		"sourceType": "module"
 	},
 	"plugins": ["@typescript-eslint"],
-	"rules": {}
+	"rules": {},
+	"ignorePatterns": ["dist", "coverage", "*.md", "*.yml", "*.yaml"]
 }

.github/dependabot.yml

@@ -3,12 +3,11 @@ updates:
   - package-ecosystem: npm
     directory: "/"
     schedule:
-      interval: daily
-      time: "16:00"
-    open-pull-requests-limit: 1
+      interval: weekly
+    ignore:
+      - dependency-name: "*"
+        update-types: ["version-update:semver-patch"]
   - package-ecosystem: github-actions
     directory: "/"
     schedule:
-      interval: daily
-      time: "16:00"
-    open-pull-requests-limit: 1
+      interval: weekly

.github/workflows/autoapprove.yml

@@ -12,6 +12,6 @@ jobs:
     runs-on: ubuntu-latest
     if: github.actor == 'dependabot[bot]' && contains(github.event.pull_request.labels.*.name, 'dependencies')
     steps:
-      - uses: hmarr/auto-approve-action@v2.1.0
+      - uses: hmarr/auto-approve-action@v4.0.0
         with:
           github-token: "${{ secrets.GITHUB_TOKEN }}"

.github/workflows/automerge.yml

@@ -17,7 +17,7 @@ jobs:
       runs-on: ubuntu-latest
       if: github.actor == 'dependabot[bot]' || github.actor == 'dependabot-preview[bot]'
       steps:
-        - uses: pascalgn/automerge-action@v0.14.3
+        - uses: pascalgn/automerge-action@v0.16.3
           env:
             GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
             MERGE_LABELS: "dependencies"

.github/workflows/build-and-test.sh

@@ -3,6 +3,18 @@ set -euxo pipefail
 
 npm install -g codecov
 
+# When running inside a Docker container, by default, we're root and all files belond to root.
+# However, calling the npm scripts (build, etc.) with 'npm run ...' runs the commands as user
+# ID=1001, which means we can't open or write to any files. Therefore, if we're in Docker, chown
+# everything under /__w (which is the workspace directory on the host: /home/runner/work) to user
+# ID=1001. See:
+# * https://github.com/ros-tooling/setup-ros/pull/521
+# * https://github.com/npm/cli/issues/4589
+docker_workdir="/__w"
+if [ -d "${docker_workdir}" ]; then
+  chown -R 1001:1001 "${docker_workdir}"
+fi
+
 npm ci
 npm run build
 npm test

.github/workflows/check-ros2-distribution.sh

@@ -2,7 +2,7 @@
 #
 # ./check-ros-distribution.sh <ROS distribution>
 # ROS distribution must match the directory name for this distribution
-# in /opt. E.g. dashing
+# in /opt. E.g. humble
 
 readonly ROS_DISTRIBUTION="$1"
 

.github/workflows/pr.yml

@@ -11,9 +11,9 @@ jobs:
     name: "Lint sources and check build artifacts"
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2.4.1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4.0.3
         with:
-          node-version: "12.x"
+          node-version: "20.x"
       - run: npm install && npm run lint
       - run: npm run build && git diff --exit-code

.github/workflows/test.yml

@@ -23,33 +23,37 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [macOS-latest, windows-latest]
+        os:
+          - macOS-latest
+          - windows-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2.4.1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4.0.3
         with:
-          node-version: "12.x"
+          node-version: "20.x"
       - run: .github/workflows/build-and-test.sh
       - uses: ./ # Uses an action in the root directory
       - run: .github/workflows/check-environment.sh
 
   test_environment_linux:
     name: "Check development tools"
     runs-on: ubuntu-latest
+    container:
+      image: ${{ matrix.docker_image }}
     strategy:
       fail-fast: false
       matrix:
         docker_image:
-          - "ubuntu:bionic"
-          - "ubuntu:focal"
-          - "ubuntu:xenial"
-    container:
-      image: ${{ matrix.docker_image }}
+          - ubuntu:20.04
+          - ubuntu:22.04
+          - ubuntu:24.04
+          - almalinux:8
+          - almalinux:9
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2.4.1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4.0.3
         with:
-          node-version: "12.x"
+          node-version: "20.x"
       - run: .github/workflows/build-and-test.sh
       - uses: ./ # Uses an action in the root directory
       - run: .github/workflows/check-environment.sh
@@ -68,16 +72,17 @@ jobs:
           # - macOS-latest
           - windows-latest
         ros_distribution:
-          # Dashing Diademata (May 2019 - May 2021)
-          - dashing
-
-          # Eloquent Elusor (November 2019 - November 2020)
-          - eloquent
+          # Humble Hawksbill (May 2022 - May 2027)
+          - humble
+          # Iron Irwini (May 2023 - November 2024)
+          - iron
+          # Jazzy Jalisco (May 2024 - May 2029)
+          - jazzy
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2.4.1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4.0.3
         with:
-          node-version: "12.x"
+          node-version: "20.x"
       - run: .github/workflows/build-and-test.sh
       - uses: ./ # Uses an action in the root directory
         with:
@@ -91,65 +96,52 @@ jobs:
         shell: cmd
         if: matrix.os == 'windows-latest'
 
-  test_ros_binary_install_ubuntu:
+  test_ros_binary_install_linux:
     name: "Check ROS distribution"
     strategy:
       fail-fast: false
       matrix:
-        ros_distribution:
-          - kinetic
-          - melodic
-          - noetic
-          - dashing
-          - eloquent
-          - foxy
-          - galactic
-          - rolling
-
         # Define the Docker image(s) associated with each ROS distribution.
         # The include syntax allows additional variables to be defined, like
         # docker_image in this case. See documentation:
         # https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-including-configurations-in-a-matrix-build
         #
         # Platforms are defined in REP 3: https://ros.org/reps/rep-0003.html
         include:
-          # Kinetic Kame (May 2016 - May 2021)
-          - docker_image: ubuntu:xenial
-            ros_distribution: kinetic
-            ros_version: 1
-
-          # Melodic Morenia (May 2018 - May 2023)
-          - docker_image: ubuntu:bionic
-            ros_distribution: melodic
-            ros_version: 1
-
           # Noetic Ninjemys (May 2020 - May 2025)
           - docker_image: ubuntu:focal
             ros_distribution: noetic
             ros_version: 1
 
-          # Dashing Diademata (May 2019 - May 2021)
-          - docker_image: ubuntu:bionic
-            ros_distribution: dashing
+          # Humble Hawksbill (May 2022 - May 2027)
+          - docker_image: ubuntu:jammy
+            ros_distribution: humble
             ros_version: 2
 
-          # Eloquent Elusor (November 2019 - November 2020)
-          - docker_image: ubuntu:bionic
-            ros_distribution: eloquent
+          - docker_image: almalinux:8
+            ros_distribution: humble
             ros_version: 2
 
-          # Foxy Fitzroy (June 2020 - May 2023)
-          - docker_image: ubuntu:focal
-            ros_distribution: foxy
+          # Iron Irwini (May 2023 - November 2024)
+          - docker_image: ubuntu:jammy
+            ros_distribution: iron
             ros_version: 2
 
-          # Galactic Geochelone (May 2021 - November 2022)
-          - docker_image: ubuntu:focal
-            ros_distribution: galactic
+          # Jazzy Jalisco (May 2024 - November 2029)
+          - docker_image: ubuntu:noble
+            ros_distribution: jazzy
+            ros_version: 2
+
+          - docker_image: almalinux:9
+            ros_distribution: jazzy
             ros_version: 2
 
           # Rolling Ridley (see REP 2002: https://www.ros.org/reps/rep-2002.html)
-          - docker_image: ubuntu:focal
+          - docker_image: ubuntu:noble
+            ros_distribution: rolling
+            ros_version: 2
+
+          - docker_image: almalinux:9
             ros_distribution: rolling
             ros_version: 2
 
@@ -158,10 +150,10 @@ jobs:
       image: ${{ matrix.docker_image }}
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2.4.1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4.0.3
         with:
-          node-version: "12.x"
+          node-version: "20.x"
       - run: .github/workflows/build-and-test.sh
       - uses: ./ # Uses an action in the root directory
         with:
@@ -172,32 +164,52 @@ jobs:
       - run: .github/workflows/check-ros2-distribution.sh "${{ matrix.ros_distribution }}"
         if: matrix.ros_version == 2
 
-  test_multiple_ros_installations:
-    name: "ROS and ROS 2 Binary Install Test Suite (Linux only)"
+  test_repo_with_root_setup_cfg:
+    name: "Test with setup.cfg file in root directory (Linux only)"
     runs-on: ubuntu-latest
     container:
-      image: ubuntu:bionic
+      image: ubuntu:24.04
     steps:
-      - uses: actions/checkout@v1
-      - uses: actions/setup-node@v2.4.1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4.0.3
         with:
-          node-version: "12.x"
+          node-version: "20.x"
       - run: .github/workflows/build-and-test.sh
+      - run: cp .github/workflows/test_setup.cfg setup.cfg
       - uses: ./ # Uses an action in the root directory
-        with:
-          required-ros-distributions: melodic dashing
-      - run: .github/workflows/check-ros2-distribution.sh dashing
-      - run: .github/workflows/check-ros-distribution.sh melodic
+      - run: colcon --help
 
   test_on_setup_ros_docker_container:
     name: "Test on a setup-ros-docker container"
     runs-on: ubuntu-latest
     container:
-      image: rostooling/setup-ros-docker:ubuntu-focal-latest
+      image: rostooling/setup-ros-docker:ubuntu-noble-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4.0.3
+        with:
+          node-version: "20.x"
+      - run: .github/workflows/build-and-test.sh
+      - uses: ./
+
+  test_install_connext:
+    name: "Test with RTI Connext DDS"
+    runs-on: ubuntu-latest
+    container:
+      image: ${{ matrix.docker_image }}
+    strategy:
+      fail-fast: false
+      matrix:
+        docker_image:
+          - ubuntu:24.04
     steps:
-      - uses: actions/checkout@v1
-      - uses: actions/setup-node@v2.4.1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4.0.3
         with:
-          node-version: "12.x"
+          node-version: "20.x"
       - run: .github/workflows/build-and-test.sh
       - uses: ./
+        with:
+          install-connext: true
+      - run: .github/workflows/check-environment.sh
+      - run: dpkg -l | grep rti-connext-dds-

.github/workflows/test_setup.cfg

@@ -0,0 +1,4 @@
+[develop]
+script_dir=$base/lib/package_name
+[install]
+install_scripts=$base/lib/package_name

.lintstagedrc.js

@@ -1,7 +1,7 @@
 module.exports = {
 	"*": [
-		"eslint --cache --fix --ignore-path .eslintignore",
-		"prettier --write --ignore-path .eslintignore --ignore-unknown",
+		"eslint --cache --fix --config .eslintrc.json",
+		"prettier --write --config .prettierrc --ignore-path .prettierignore --ignore-unknown",
 		// Note: doing the build here ensures we omit unstaged changes
 		() => "npm run build",
 		() => "git add dist/index.js",

.prettierignore

@@ -0,0 +1,5 @@
+dist
+coverage
+*.md
+*.yml
+*.yaml

DEVELOPING.md

@@ -4,7 +4,13 @@
 
 Install [Node.js](https://nodejs.org/en/download/).
 
-We are currently using Node.js v12.
+We are currently using Node.js v20.
+
+## Install dependencies
+
+```sh
+npm install
+```
 
 ## Setup git hooks
 
@@ -17,8 +23,6 @@ npm run prepare
 ## Build and test
 
 ```sh
-# install dependencies
-npm install
 # autoformat sources to meet enforced linter style
 npm run fixup
 # generate build artifacts (run automatically when committing if git hooks are installed)
@@ -47,3 +51,5 @@ Release process
 1. Create a new release and publish it to the marketplace via https://github.com/ros-tooling/setup-ros/releases/new using the patch-level tag that you created
 1. Push the minor version tag now that the release is officially out. Users will get the new version automatically
     * `git push -f origin v0.1`
+1. For a new minor release, update version in examples given in `README.md`
+    * Search for `ros-tooling/setup-ros@v0.N`