Empty Form Action Fix #765
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
korgon
commented
Mar 13, 2023
korgon
commented
- getting form action from attribute instead of from the property
…ead of from the property
chrisFrazier77
previously approved these changes
Mar 13, 2023
…ecent fix to AC controller
|
@chrisFrazier77, unfortunately I had to reverse the AC E2E test due to this change (see screenshot). I think this is going to be a real problem for all implementations repositories... likely this will push us to implement a "find and replace" capability into Snapfu patching.
|
|
This solves a very small edge case (when there is no form action). The current fix would break testing on most sites - need to see if there is a non-test-breaking way to move this forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.