Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty Form Action Fix #765

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Empty Form Action Fix #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32fce12
fix(controller-autocomplete): getting form action from attribute inst…
korgon Mar 13, 2023
659f72f
test(controller-autocomplete): adjusting test after adjusting form ac…
korgon Mar 13, 2023
266ee8c
fix(controller-autocomplete): changing order of AC assertion due to r…
korgon Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/snap-controller/src/Autocomplete/AutocompleteController.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ describe('Autocomplete Controller', () => {

expect(controller.urlManager.state.query).toBe(query);
expect(controller.store.state.input).toBe(query);
expect(controller.store.state.url.href).toBe('http://localhost/search.html?search_query=white');
expect(controller.store.state.url.href).toBe('/search.html?search_query=white');
});

it('serializes other form input elements (settings.serializeForm)', async () => {
Expand Down Expand Up @@ -390,7 +390,7 @@ describe('Autocomplete Controller', () => {

expect(controller.urlManager.state.query).toBe(query);
expect(controller.store.state.input).toBe(query);
expect(controller.store.state.url.href).toBe('http://localhost/search.html?view=shop&search_query=white');
expect(controller.store.state.url.href).toBe('/search.html?view=shop&search_query=white');
});

it('can invoke controller track.product.click', async () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/snap-controller/src/Autocomplete/AutocompleteController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ export class AutocompleteController extends AbstractController {
formActionUrl = this.config.action;
} else if (form) {
form.addEventListener('submit', this.handlers.input.formSubmit as unknown as EventListener);
formActionUrl = form.action || '';
formActionUrl = form.getAttribute('action') || '';

if (this.config.settings?.serializeForm) {
bindFormParameters(form, this.handlers.input.formElementChange, function (elem: HTMLInputElement) {
Expand Down
2 changes: 1 addition & 1 deletion packages/snap-preact-demo/tests/cypress/integration/autocomplete/autocomplete.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ describe('Autocomplete', () => {

cy.snapController('autocomplete').then(({ store }) => {
cy.wrap(store.services.urlManager.state.filter).should('exist');
cy.wrap(store.services.urlManager.href).should('contain', optionURL);
cy.wrap(optionURL).should('contain', store.services.urlManager.href);
});
});
});
Expand Down