Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project with customRunnerConfiguration fails test phase even when mvn -DskipTests clean install #206

Merged

Conversation

klieber
Copy link
Collaborator

@klieber klieber commented Dec 20, 2013

We have a following setup:

  1. customConfigurationRunner runner is first extracted to target/ directory (as it comes from external dependency)
  2. configure jasmine maven plugin to use this customConfigurationRunner
  3. launch the build using mvn -DskipTests install

Jasmine maven plugin fails at not finding the file

Error message:
com.github.searls:jasmine-maven-plugin:1.3.1.2:test (default) on project XY: Invalid value for parameter 'customRunnerConfiguration'. File does not exist: XY/target/jasmine/src/ext/requirejs-config.js

The code should not check this condition if -DskipTests is set

@ghost ghost assigned klieber Dec 3, 2013
klieber added a commit that referenced this pull request Dec 20, 2013
…tests

Project with customRunnerConfiguration fails test phase even when mvn -DskipTests clean install
@klieber klieber merged commit bcb642c into searls:master Dec 20, 2013
@klieber klieber deleted the issue/206_failure_when_skipping_tests branch February 18, 2014 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant